linux-kernel - Re: [PATCH v2] staging: nvec: Remove unused NVEC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKQUPPlr4hJS1UTe@stanley.mountain>
Date: Tue, 19 Aug 2025 09:05:48 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Mohammed Guermoud <mohammed.guermoud@...il.com>
Cc: marvin24@....de, gregkh@...uxfoundation.org, ac100@...ts.launchpad.net,
	linux-tegra@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] staging: nvec: Remove unused NVEC_PHD macro

On Mon, Aug 18, 2025 at 09:38:55PM +0100, Mohammed Guermoud wrote:
> The NVEC_PHD macro is a debugging helper that is only enabled when
> NVEC_PS2_DEBUG is defined. As this flag is never defined in the kernel,
> the macro and all of its call sites are dead code.
> 
> As suggested by Greg Kroah-Hartman, removing the code is the cleanest
> solution. This also fixes a build error discovered by the kernel test
> robot after the v1 patch modified the macro's body.

We don't reference v1 here.  We would do it under the --- cut off.

> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508182005.4PiKxXcN-lkp@intel.com/

Don't add these tags.  They're just confusing because we never merged v1.

> Signed-off-by: Mohammed Guermoud <mohammed.guermoud@...il.com>
> ---
Here you would put a comment like:

v2: version caused a build error.  It's better to just delete the
    code instead of trying to silence the warning.

Please send v3 with a comment:

v3: Fix commit message.
v2: version caused a build error.  It's better to just delete the
    code instead of trying to silence the warning.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter