linux-kernel - Re: [RFC PATCH -next 03/16] mm/damon/paddr: support addr_unit for DAMOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250819062613.39988-1-sj@kernel.org>
Date: Mon, 18 Aug 2025 23:26:13 -0700
From: SeongJae Park <sj@...nel.org>
To: SeongJae Park <sj@...nel.org>
Cc: Quanmin Yan <yanquanmin1@...wei.com>,
	akpm@...ux-foundation.org,
	damon@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	linux-mm@...ck.org,
	wangkefeng.wang@...wei.com,
	zuoze1@...wei.com
Subject: Re: [RFC PATCH -next 03/16] mm/damon/paddr: support addr_unit for DAMOS_PAGEOUT

On Mon, 18 Aug 2025 23:18:26 -0700 SeongJae Park <sj@...nel.org> wrote:

> Hi Quanmin,
> 
> 
> 
> On Wed, 13 Aug 2025 13:06:53 +0800 Quanmin Yan <yanquanmin1@...wei.com> wrote:
> 
> > From: SeongJae Park <sj@...nel.org>
> > 
> > Add support of addr_unit for DAMOS_PAGEOUT action handling from the
> > DAMOS operation implementation for the physical address space.
> 
> As I suggested on another reply[1], please squash attaching patch to this one
> when you post next version of this series.
> 
> [1] https://lore.kernel.org/0001-mm-damon-paddr-set-DAMOS_PAGEOUT-stat-in-core-addres.patch

Sorry for the above wrong link.  Plese use
https://lore.kernel.org/20250813170806.6251-1-sj@kernel.org instead.

> 
> [...]
> 
> 
> Thanks,
> SJ
> 
> ==== Attachment 0 (0001-mm-damon-paddr-set-DAMOS_PAGEOUT-stat-in-core-addres.patch) ====
> >From 525b3d1d9dd53f4ca6b4d2254e5cc7f99c8eae0d Mon Sep 17 00:00:00 2001
> From: SeongJae Park <sj@...nel.org>
> Date: Wed, 13 Aug 2025 21:24:35 -0700
> Subject: [PATCH] mm/damon/paddr: set DAMOS_PAGEOUT stat in core address unit
> 
> Operations layer should set DAMOS stat in core layer address unit, but
> paddr is returning that for PAGEOUT in paddr address unit.  Fix it.
> 
> Signed-off-by: SeongJae Park <sj@...nel.org>
> ---
>  mm/damon/paddr.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c
> index 98cb6930c183..826c2064dbfd 100644
> --- a/mm/damon/paddr.c
> +++ b/mm/damon/paddr.c
> @@ -139,8 +139,7 @@ static unsigned long damon_pa_pageout(struct damon_region *r,
>  		unsigned long addr_unit, struct damos *s,
>  		unsigned long *sz_filter_passed)
>  {
> -	phys_addr_t addr;
> -	unsigned long applied;
> +	phys_addr_t addr, applied;
>  	LIST_HEAD(folio_list);
>  	bool install_young_filter = true;
>  	struct damos_filter *filter;
> @@ -172,7 +171,7 @@ static unsigned long damon_pa_pageout(struct damon_region *r,
>  		if (damos_pa_filter_out(s, folio))
>  			goto put_folio;
>  		else
> -			*sz_filter_passed += folio_size(folio);
> +			*sz_filter_passed += folio_size(folio) / addr_unit;
>  
>  		folio_clear_referenced(folio);
>  		folio_test_clear_young(folio);
> @@ -191,7 +190,7 @@ static unsigned long damon_pa_pageout(struct damon_region *r,
>  	applied = reclaim_pages(&folio_list);
>  	cond_resched();
>  	s->last_applied = folio;
> -	return applied * PAGE_SIZE;
> +	return applied * PAGE_SIZE / addr_unit;
>  }
>  
>  static inline unsigned long damon_pa_mark_accessed_or_deactivate(
> -- 
> 2.39.5
> 
>