[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <175558495586.3265727.15591420113777968646.robh@kernel.org>
Date: Tue, 19 Aug 2025 01:29:18 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: biju.das.jz@...renesas.com, linux-phy@...ts.infradead.org,
kishon@...nel.org, krzk+dt@...nel.org, p.zabel@...gutronix.de,
yoshihiro.shimoda.uh@...esas.com, conor+dt@...nel.org,
magnus.damm@...il.com, geert+renesas@...der.be, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
vkoul@...nel.org
Subject: Re: [PATCH v5 3/7] dt-bindings: reset: renesas,rzg2l-usbphy-ctrl:
Document RZ/G3S support
On Tue, 19 Aug 2025 08:42:08 +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> The Renesas USB PHY hardware block needs to have the PWRRDY bit in the
> system controller set before applying any other settings. The PWRRDY bit
> must be controlled during power-on, power-off, and system suspend/resume
> sequences as follows:
> - during power-on/resume, it must be set to zero before enabling clocks and
> modules
> - during power-off/suspend, it must be set to one after disabling clocks
> and modules
>
> Add the renesas,sysc-pwrrdy device tree property, which allows the
> reset-rzg2l-usbphy-ctrl driver to parse, map, and control the system
> controller PWRRDY bit at the appropriate time. Along with it add a new
> compatible for the RZ/G3S SoC.
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> ---
>
> Changes in v5:
> - fixed description formatting
> - collected tags
>
> Changes in v4:
> - dropped blank line from compatible section
> - s/renesas,sysc-signals/renesas,sysc-pwrrdy/g
> - dropped description from renesas,sysc-pwrrdy
> - updated description of renesas,sysc-pwrrdy items
> - updated patch description
>
> Changes in v3:
> - none; this patch is new
>
> .../reset/renesas,rzg2l-usbphy-ctrl.yaml | 41 ++++++++++++++++---
> 1 file changed, 35 insertions(+), 6 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250819054212.486426-4-claudiu.beznea.uj@bp.renesas.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists