linux-kernel - Re: [PATCH 4/4] dt-bindings: arm: mediatek: Add grinn,genio-510-sbc as a valid platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e78051b-ec79-4b6d-a59e-6745f6caaf37@kernel.org>
Date: Tue, 19 Aug 2025 08:54:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mateusz Koza <mateusz.koza@...nn-global.com>,
 angelogioacchino.delregno@...labora.com, robh@...nel.org
Cc: krzk+dt@...nel.org, conor+dt@...nel.org, matthias.bgg@...il.com,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
 marcin.czarnecki@...nn-global.com, b.bilas@...nn-global.com
Subject: Re: [PATCH 4/4] dt-bindings: arm: mediatek: Add grinn,genio-510-sbc
 as a valid platform

On 15/08/2025 18:08, Mateusz Koza wrote:
> Add device tree bindings support for the Grinn GenioSBC-510, a
> single-board computer based on the MediaTek Genio 510 SoC.
> 
> The new compatible string "grinn,genio-510-sbc" identifies this board in
> the device tree bindings, enabling future board-specific adjustments if
> required.

Drop, completely redundant statement. Do not explain to us how DT works
- we all know. Same for all other commits.

> 
> More details about the hardware:
> - https://grinn-global.com/products/grinn-geniosom-510
> - https://grinn-global.com/products/grinn-genioboard-edge-ai-sbc
> 
> Signed-off-by: Mateusz Koza <mateusz.koza@...nn-global.com>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index ad7fb85e3559..92ecc689430f 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -426,6 +426,7 @@ properties:
>        - items:
>            - enum:
>                - mediatek,mt8370-evk
> +              - grinn,genio-510-sbc
Also wrong order.

Best regards,
Krzysztof