linux-kernel - Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38734ae6-012d-4630-8bf3-efefb65f0d23@redhat.com>
Date: Tue, 19 Aug 2025 09:28:20 +0200
From: David Hildenbrand <david@...hat.com>
To: Aboorva Devarajan <aboorvad@...ux.ibm.com>, akpm@...ux-foundation.org
Cc: Liam.Howlett@...cle.com, lorenzo.stoakes@...cle.com, shuah@...nel.org,
 pfalcato@...e.de, ziy@...dia.com, baolin.wang@...ux.alibaba.com,
 npache@...hat.com, ryan.roberts@....com, dev.jain@....com,
 baohua@...nel.org, richard.weiyang@...il.com, linux-mm@...ck.org,
 linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
 donettom@...ux.ibm.com, ritesh.list@...il.com
Subject: Re: [Fixup PATCH] mm/selftests: Fix formattig in split_huge_page_test

On 19.08.25 09:25, David Hildenbrand wrote:
> On 19.08.25 06:12, Aboorva Devarajan wrote:
>> Removed an extra space in split_huge_page_test that was introduced
>> by commit 4b76e221794b ("mm/selftests: fix split_huge_page_test
>> failure on systems with 64KB page size").
>>
>> Signed-off-by: Aboorva Devarajan <aboorvad@...ux.ibm.com>
>> ---
>>    tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
>> index 54e86f00aabc..faf7e1f88743 100644
>> --- a/tools/testing/selftests/mm/split_huge_page_test.c
>> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
>> @@ -544,7 +544,7 @@ int main(int argc, char **argv)
>>    		ksft_exit_fail_msg("Reading PMD pagesize failed\n");
>>    
>>    	nr_pages = pmd_pagesize / pagesize;
>> -	max_order =  sz2ord(pmd_pagesize, pagesize);
>> +	max_order = sz2ord(pmd_pagesize, pagesize);
>>    	tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - 1) * 4 + 2;
>>    	ksft_set_plan(tests);
>>    
> 
> Please just comment next time one the respective patch as review comment.
> 

To clarify what I mean is something like this:

https://lkml.kernel.org/r/3dca2de4-9a6a-4efe-a86c-83f9509831fc@gmail.com

Gives more context when the subject directly highlights to which patch 
you are replying.

-- 
Cheers

David / dhildenb