linux-kernel - RE: [PATCH v7 4/6] arm64: dts: renesas: r9a09g047: Add #address-cells property in sys node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <OSCPR01MB146478959897629D628727CB5FF30A@OSCPR01MB14647.jpnprd01.prod.outlook.com>
Date: Tue, 19 Aug 2025 08:25:17 +0000
From: John Madieu <john.madieu.xa@...renesas.com>
To: geert <geert@...ux-m68k.org>
CC: magnus.damm <magnus.damm@...il.com>, "mturquette@...libre.com"
	<mturquette@...libre.com>, "sboyd@...nel.org" <sboyd@...nel.org>,
	"rafael@...nel.org" <rafael@...nel.org>, "daniel.lezcano@...aro.org"
	<daniel.lezcano@...aro.org>, "rui.zhang@...el.com" <rui.zhang@...el.com>,
	"lukasz.luba@....com" <lukasz.luba@....com>, "robh@...nel.org"
	<robh@...nel.org>, "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "catalin.marinas@....com"
	<catalin.marinas@....com>, "will@...nel.org" <will@...nel.org>,
	"john.madieu@...il.com" <john.madieu@...il.com>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, Biju Das
	<biju.das.jz@...renesas.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v7 4/6] arm64: dts: renesas: r9a09g047: Add #address-cells
 property in sys node

Hi Geert,

Thanks for your review!

> -----Original Message-----
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Sent: Tuesday, August 19, 2025 9:44 AM
> To: John Madieu <john.madieu.xa@...renesas.com>
> Subject: Re: [PATCH v7 4/6] arm64: dts: renesas: r9a09g047: Add #address-
> cells property in sys node
> 
> Hi John,
> 
> On Mon, 18 Aug 2025 at 18:29, John Madieu <john.madieu.xa@...renesas.com>
> wrote:
> > A couple of registers of the system controller (sys) are shared with
> > the TSU device. Add #address-cells property to sys node to allow
> > proper parsing a access to these registers from the TSU driver.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@...renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -278,6 +278,7 @@ sys: system-controller@...30000 {
> >                         reg = <0 0x10430000 0 0x10000>;
> >                         clocks = <&cpg CPG_CORE R9A09G047_SYS_0_PCLK>;
> >                         resets = <&cpg 0x30>;
> > +                       #address-cells = <1>;
> 
> Iff you need this, you need to update the DT bindings first, as reported by
> Rob's bot.
> 
> However, looking at Claudiu's USB series [1], I think you can do without,
> by calling of_parse_phandle_with_fixed_args() instead of
> of_parse_phandle_with_args() in the driver.
> 
> >                 };

Indeed, I'll use the fixed_args() option and drop this patch
in v8.

> >
> >                 xspi: spi@...30000 {
> 
> [1] "[PATCH v5 0/7] Add initial USB support for the Renesas RZ/G3S SoC"
>     https://lore.kernel.org/20250819054212.486426-1-
> claudiu.beznea.uj@...renesas.com
> 
> Gr{oetje,eeting}s,

Regards,
John

> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds