linux-kernel - Re: [PATCH v4 1/2] dt-bindings: PCI: dwc: Add vaux regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175559221431.3513325.13023489258693158920.robh@kernel.org>
Date: Tue, 19 Aug 2025 03:30:14 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Richard Zhu <hongxing.zhu@....com>
Cc: festevam@...il.com, linux-pci@...r.kernel.org, 
 devicetree@...r.kernel.org, krzk+dt@...nel.org, s.hauer@...gutronix.de, 
 lpieralisi@...nel.org, shawnguo@...nel.org, frank.li@....com, 
 l.stach@...gutronix.de, bhelgaas@...gle.com, mani@...nel.org, 
 conor+dt@...nel.org, kernel@...gutronix.de, kwilczynski@...nel.org, 
 linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: PCI: dwc: Add vaux regulator


On Tue, 19 Aug 2025 15:16:29 +0800, Richard Zhu wrote:
> Refer to PCIe CEM r6.0, sec 2.3 WAKE# Signal, WAKE# signal is only
> asserted by the Add-in Card when all its functions are in D3Cold state
> and at least one of its functions is enabled for wakeup generation.
> 
> The 3.3V auxiliary power (+3.3Vaux) must be present and used for wakeup
> process. Since the main power supply would be gated off to let Add-in
> Card to be in D3Cold, add the vaux and keep it enabled to power up WAKE#
> circuit for the entire PCIe controller lifecycle when WAKE# is supported.
> 
> Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> ---
>  .../devicetree/bindings/pci/snps,dw-pcie-common.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:


doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250819071630.1813134-2-hongxing.zhu@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.