linux-kernel - Re: [PATCH v3 2/2] HID: Make elan touch controllers power on after panel is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <pr01os80-s752-1rqp-782q-65nr8222npq7@xreary.bet>
Date: Tue, 19 Aug 2025 10:55:38 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Doug Anderson <dianders@...omium.org>
cc: Pin-yen Lin <treapking@...omium.org>, 
    Neil Armstrong <neil.armstrong@...aro.org>, 
    Jessica Zhang <quic_jesszhan@...cinc.com>, 
    Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
    Maxime Ripard <mripard@...nel.org>, 
    Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, 
    Simona Vetter <simona@...ll.ch>, Benjamin Tissoires <bentiss@...nel.org>, 
    linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, 
    Chen-Yu Tsai <wenst@...omium.org>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v3 2/2] HID: Make elan touch controllers power on after
 panel is enabled

On Mon, 18 Aug 2025, Doug Anderson wrote:

> > Introduce a new HID quirk to indicate that this device has to be enabled
> > after the panel's backlight is enabled, and update the driver data for
> > the elan devices to enable this quirk. This cannot be a I2C HID quirk
> > because the kernel needs to acknowledge this before powering up the
> > device and read the VID/PID. When this quirk is enabled, register
> > .panel_enabled()/.panel_disabling() instead for the panel follower.
> >
> > Also rename the *panel_prepare* functions into *panel_follower* because
> > they could be called in other situations now.
> >
> > Fixes: bd3cba00dcc63 ("HID: i2c-hid: elan: Add support for Elan eKTH6915 i2c-hid touchscreens")
> > Fixes: d06651bebf99e ("HID: i2c-hid: elan: Add elan-ekth6a12nay timing")
> >
> > Reviewed-by: Douglas Anderson <dianders@...omium.org>
> > Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> >
> > ---
> >
> > Changes in v3:
> > - Collect review tag
> > - Add fixes tags
> >
> > Changes in v2:
> > - Rename *panel_prepare* functions to *panel_follower*
> > - Replace after_panel_enabled flag with enabled/disabling callbacks
> >
> >  drivers/hid/i2c-hid/i2c-hid-core.c    | 46 ++++++++++++++++-----------
> >  drivers/hid/i2c-hid/i2c-hid-of-elan.c | 11 ++++++-
> >  include/linux/hid.h                   |  2 ++
> >  3 files changed, 40 insertions(+), 19 deletions(-)
> 
> Re-iterating my response from v2 [1] so it's still seen even if people
> only look at the latest version. :-) If HID folks don't mind us
> landing this through drm-misc, feel free to Ack this patch. 

Acked-by: Jiri Kosina <jkosina@...e.com>

Thanks!

-- 
Jiri Kosina
SUSE Labs