linux-kernel - Re: [PATCH v2 3/3] usb: usb251xb: support usage case without I2C control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250819-shrimp-of-weird-efficiency-39bfef@kuoka>
Date: Tue, 19 Aug 2025 11:24:33 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Richard Leitner <richard.leitner@...ux.dev>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-usb@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] usb: usb251xb: support usage case without I2C
 control

On Tue, Aug 19, 2025 at 08:22:17AM +0800, Jisheng Zhang wrote:
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(usb251xb_plat_pm_ops, usb251xb_plat_suspend, usb251xb_plat_resume);
> +
> +static struct platform_driver usb251xb_plat_driver = {
> +	.driver = {
> +		.name = DRIVER_NAME,
> +		.of_match_table = of_match_ptr(usb251xb_of_match),

No, drop of_match_ptr. This is neither correct nor helpful.
Look at existing code.

Best regards,
Krzysztof