linux-kernel - Re: [PATCH] RISC-V: KVM: Using user-mode pte within kvm_riscv_gstage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK9=C2XN3izaV_cB5dTkRD0FRD+gqdRVYWKxMAuaCG+LP3D2aw@mail.gmail.com>
Date: Tue, 19 Aug 2025 15:27:01 +0530
From: Anup Patel <apatel@...tanamicro.com>
To: fangyu.yu@...ux.alibaba.com
Cc: anup@...infault.org, alex@...ti.fr, aou@...s.berkeley.edu, 
	atish.patra@...ux.dev, guoren@...ux.alibaba.com, 
	kvm-riscv@...ts.infradead.org, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	palmer@...belt.com, paul.walmsley@...ive.com
Subject: Re: [PATCH] RISC-V: KVM: Using user-mode pte within kvm_riscv_gstage_ioremap

On Tue, Aug 19, 2025 at 6:56 AM <fangyu.yu@...ux.alibaba.com> wrote:
>
> >>
> >> From: Fangyu Yu <fangyu.yu@...ux.alibaba.com>
> >>
> >> Currently we use kvm_riscv_gstage_ioremap to map IMSIC gpa to the spa of
> >> guest interrupt file within IMSIC.
> >>
> >> The PAGE_KERNEL_IO property does not include user mode settings, so when
> >> accessing the IMSIC address in the virtual machine,  a  guest page fault
> >> will occur, this is not expected.
> >>
> >> According to the RISC-V Privileged Architecture Spec, for G-stage address
> >> translation, all memory accesses are considered to be user-level accesses
> >> as though executed in Umode.
> >>
> >> Signed-off-by: Fangyu Yu <fangyu.yu@...ux.alibaba.com>
> >
> >Overall, a good fix. Thanks!
> >
> >The patch subject and description needs improvements. Also, there is no
> >Fixes tag which is required for backporting.
> >
> >I have taken care of the above things at the time of merging this patch.
> >
> >Queued this patch as fixes for Linux-6.17
> >
> >Thanks,
> >Anup
> >
>
> Thanks for your review.
> I will send a v2 patch to fix these comments.

No need, it's already part of my riscv_kvm_fixes branch at:
https//github.com/kvm-riscv/linux.git

Regards,
Anup