linux-kernel - Re: [PATCH next] io: proximity: vl53l0x-i2c: Fix error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VeTL7mJ-Ttgpkjd5A04DgHqkkPY90LtJriQjoaUZ0TbhQ@mail.gmail.com>
Date: Tue, 19 Aug 2025 13:18:35 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Waqar Hameed <waqar.hameed@...s.com>, Song Qiang <songqiang1304521@...il.com>, 
	Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>, 
	Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] io: proximity: vl53l0x-i2c: Fix error code in probe()

On Tue, Aug 19, 2025 at 12:39 PM Dan Carpenter <dan.carpenter@...aro.org> wrote:
>
> Commit 65e8202f0322 ("iio: Remove error prints for
> devm_add_action_or_reset()") accidentally introduce a bug where we

introduced

> returned "ret" but the error code was stored in "error" if
> devm_add_action_or_reset() failed.  Using two variables to store error
> codes is unnecessary and confusing.  Delete the "error" variable and use
> "ret" everywhere instead.

Agree, this is a good catch!
But please, fix the Subject to start with "iio:".

With the above comments being addressed
Reviewed-by: Andy Shevchenko <andy@...nel.org>


-- 
With Best Regards,
Andy Shevchenko