Message-ID: <20250819013941.209033-1-irogers@google.com>
Date: Mon, 18 Aug 2025 18:39:30 -0700
From: Ian Rogers <irogers@...gle.com>
To: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Arnaldo Carvalho de Melo <acme@...nel.org>, Namhyung Kim <namhyung@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Ian Rogers <irogers@...gle.com>, Adrian Hunter <adrian.hunter@...el.com>, 
	Kan Liang <kan.liang@...ux.intel.com>, James Clark <james.clark@...aro.org>, 
	Xu Yang <xu.yang_2@....com>, "Masami Hiramatsu (Google)" <mhiramat@...nel.org>, 
	Collin Funk <collin.funk1@...il.com>, Howard Chu <howardchu95@...il.com>, 
	Weilin Wang <weilin.wang@...el.com>, Andi Kleen <ak@...ux.intel.com>, 
	"Dr. David Alan Gilbert" <linux@...blig.org>, Thomas Richter <tmricht@...ux.ibm.com>, 
	Tiezhu Yang <yangtiezhu@...ngson.cn>, Gautam Menghani <gautam@...ux.ibm.com>, 
	Thomas Falcon <thomas.falcon@...el.com>, Chun-Tse Shao <ctshao@...gle.com>, 
	linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Subject: [PATCH v10 00/11] New perf ilist app

This patch series adds a new ilist app written in python using textual
[1] for the UI. The app presents perf PMUs and events, displays the
event information as in `perf list` while at the bottom of the console
showing recent activity of the event in total and across all CPUs. It
also displays metrics, placed in a tree through their metric group,
again with counts being displayed in the bottom panel.

To run it you need the updated perf.cpython.so in your PYTHONPATH and
then execute the script. Expanding PMUs and then selecting events will
cause event informatin to be displayed in the top-right and the
counters values to be displayed as sparklines and counts in the bottom
half of the screen.

There's been feedback on how the app works, simplicity of
implementation has been chosen as the first criteria as the app can be
further refined from what is here. The choice of the name ilist rather
than say istat was deliberate as I wanted the app to encourage PMU,
event and metric discovery, as with perf list. The output counts and
spark lines are just to give an indication of what the event
gathers. ilist comes from interactive list, there's probably a better
name.

[1] https://textual.textualize.io/

v10: Add Howard's reviewed-by and address documentation fix. Rebase
     and drop build up patches merged in v6.17 by Namhyung.

v9: sys metric support and pep8 clean up suggested by Xu Yang
    <xu.yang_2@....com>.

v8: nit fixing of issues caught by Arnaldo and Namhyung. Add Arnaldo's
    tested-by. Fail to repro issue reported by Thomas Falcon but
    encounter textual rendering and DOM query race, add an exception
    handling path to avoid the race being fatal. The change is minor
    in patch 16, so Arnaldo's tested-by is kept.

v7: Better handle errors in the python code and ignore errors when
    scanning PMU/events in ilist.py, improving the behavior when not
    root. Add a tp_pmu/python clean up. Minor kernel coding style
    clean up. Fix behavior of ilist if a search result isn't found but
    then next is chosen.

v6: For metrics on hybrid systems don't purely match by name, also
    match the CPU and thread so that if the same metric exists for
    different PMUs the appropriate one is selected and counters may be
    read. Likewise use evsel maps and not the evlists.

v5: Split the series in two. Add metric support. Various clean ups and
    tweaks to the app in particular around the handling of searches.

v4: No conflict rebase. Picks up perf-tools-next DRM PMU which
    displays as expected.

v3: Add a search dialog to the ilist app with 'n'ext and 'p'revious
    keys. No changes in the ground work first 14 patches.

v2: In the jevents event description duplication, some minor changes
    accidentally missed from v1 meaning that in v1 the descriptions
    were still duplicated. Expand the cover letter with some thoughts
    on the series.

Ian Rogers (11):
  perf python: Add more exceptions on error paths
  perf python: Improve the tracepoint function if no libtraceevent
  perf python: Add basic PMU abstraction and pmus sequence
  perf python: Add function returning dictionary of all events on a PMU
  perf ilist: Add new python ilist command
  perf python: Add parse_metrics function
  perf python: Add evlist metrics function
  perf python: Add evlist compute_metric
  perf python: Add metrics function
  perf ilist: Add support for metrics
  perf tp_pmu: Remove unnecessary check

 tools/perf/python/ilist.py | 495 +++++++++++++++++++++++++++++++++++
 tools/perf/util/python.c   | 522 ++++++++++++++++++++++++++++++++++++-
 tools/perf/util/tp_pmu.c   |   2 -
 3 files changed, 1004 insertions(+), 15 deletions(-)
 create mode 100755 tools/perf/python/ilist.py

-- 
2.51.0.rc1.167.g924127e9c0-goog

Powered by blists - more mailing lists