lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250819111044.2714855-1-heiko@sntech.de>
Date: Tue, 19 Aug 2025 13:10:44 +0200
From: Heiko Stuebner <heiko@...ech.de>
To: srini@...nel.org
Cc: linux-kernel@...r.kernel.org,
	heiko@...ech.de,
	kernel test robot <lkp@...el.com>
Subject: [PATCH] nvmem: qnap-mcu-eeprom: swap header order to fix missing type definitions

The main header for the qnap-mcu uses types without (at the moment)
including the necessary types.h header.

While there is patch pending to fix that for every use:
  https://lore.kernel.org/all/20250804130726.3180806-2-heiko@sntech.de/
this does not help the nvmem driver right now.

Swapping the order of module.h and qnap-mcu.h headers does fix the
problem locally until the main change gets merged though.

Fixes: 117c3f3014a9 ("nvmem: add driver for the eeprom in qnap-mcu controllers")
Reported-by: kernel test robot <lkp@...el.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202508191205.ROvIX7IA-lkp@intel.com/
Signed-off-by: Heiko Stuebner <heiko@...ech.de>
---
 drivers/nvmem/qnap-mcu-eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eeprom.c
index fea1e7b91764..e18e9ff4cfce 100644
--- a/drivers/nvmem/qnap-mcu-eeprom.c
+++ b/drivers/nvmem/qnap-mcu-eeprom.c
@@ -9,8 +9,8 @@
  * Copyright (C) 2008 Wolfram Sang, Pengutronix
  */
 
-#include <linux/mfd/qnap-mcu.h>
 #include <linux/module.h>
+#include <linux/mfd/qnap-mcu.h>
 #include <linux/nvmem-provider.h>
 #include <linux/platform_device.h>
 
-- 
2.47.2


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ