linux-kernel - Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9fe9d86e-0d24-4877-aefc-438248d7024e@kernel.org>
Date: Wed, 20 Aug 2025 15:08:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yijie Yang <yijie.yang@....qualcomm.com>, Vinod Koul <vkoul@...nel.org>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Richard Cochran <richardcochran@...il.com>
Cc: netdev@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org, stable+noautosel@...nel.org,
 Yijie Yang <quic_yijiyang@...cinc.com>,
 Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v4 3/6] arm64: dts: qcom: qcs615: add ethernet node

On 20/08/2025 10:57, Yijie Yang wrote:
> 
> 
> On 2025-08-19 17:08, Krzysztof Kozlowski wrote:
>> On 19/08/2025 11:04, Yijie Yang wrote:
>>>
>>>
>>> On 2025-08-19 15:15, Krzysztof Kozlowski wrote:
>>>> On 19/08/2025 08:51, Yijie Yang wrote:
>>>>>
>>>>>
>>>>> On 2025-08-19 14:44, Krzysztof Kozlowski wrote:
>>>>>> On 19/08/2025 08:35, YijieYang wrote:
>>>>>>> From: Yijie Yang <quic_yijiyang@...cinc.com>
>>>>>>>
>>>>>>> Add an ethernet controller node for QCS615 SoC to enable ethernet
>>>>>>> functionality.
>>>>>>>
>>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>>>>> Signed-off-by: Yijie Yang <quic_yijiyang@...cinc.com>
>>>>>>> ---
>>>>>>
>>>>>>
>>>>>> Why do you mix up DTS and net-next patches? This only makes difficult to
>>>>>> apply it, for no benefits.
>>>>>
>>>>> The DTS changes and driver code modifications work together to achieve a
>>>>> single purpose, so I included them in one patch series. Should I
>>>>> consider splitting them into two separate series?
>>>> Of course yes. You are just making difficult to apply this. Patches are
>>>> completely independent and even your internal guideline asks to NOT
>>>> combine independent patches.
>>>
>>> The challenge with splitting this series lies in the fact that it
>>> attempts to reverse the incorrect semantics of phy-mode in both the
>>> driver code and the device tree. Selecting only part of the series would
>>> break Ethernet functionality on both boards.
>>
>> And where did you explain that? Anyway, you did not achieve your goal,
>> because you broke the boards still.
>>
>> Your patchset is not bisectable and does not follow standard submission
>> guidelines. DTS is always independent, please read carefully the docs.
> 
> The approach I'm taking will inevitably make the series non-bisectable, 

The series are non-bisectable now!

Do you understand the concept of commit and how patch is applied? How
splitting this patchset per two changes ANYTHING in bisectability?

And you keep arguing on this...

Best regards,
Krzysztof