linux-kernel - [PATCH] i2c: amd-asf: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250820131638.502644-1-liaoyuanhong@vivo.com>
Date: Wed, 20 Aug 2025 21:16:37 +0800
From: Liao Yuanhong <liaoyuanhong@...o.com>
To: Shyam Sundar S K <shyam-sundar.s-k@....com>,
	Andi Shyti <andi.shyti@...nel.org>,
	linux-i2c@...r.kernel.org (open list:AMD ASF I2C DRIVER),
	linux-kernel@...r.kernel.org (open list)
Cc: Liao Yuanhong <liaoyuanhong@...o.com>
Subject: [PATCH] i2c: amd-asf: Remove the use of dev_err_probe()

Logging messages that show some type of "out of memory" error are generally
unnecessary as there is a generic message and a stack dump done by the
memory subsystem. These messages generally increase kernel size without
much added value[1].

The dev_err_probe() doesn't do anything when error is '-ENOMEM'. Therefore,
remove the useless call to dev_err_probe(), and just return the value
instead.

[1]: https://lore.kernel.org/lkml/1402419340.30479.18.camel@joe-AO725/

Signed-off-by: Liao Yuanhong <liaoyuanhong@...o.com>
---
 drivers/i2c/busses/i2c-amd-asf-plat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-amd-asf-plat.c b/drivers/i2c/busses/i2c-amd-asf-plat.c
index ca45f0f23321..1484bba46305 100644
--- a/drivers/i2c/busses/i2c-amd-asf-plat.c
+++ b/drivers/i2c/busses/i2c-amd-asf-plat.c
@@ -306,7 +306,7 @@ static int amd_asf_probe(struct platform_device *pdev)
 
 	asf_dev = devm_kzalloc(dev, sizeof(*asf_dev), GFP_KERNEL);
 	if (!asf_dev)
-		return dev_err_probe(dev, -ENOMEM, "Failed to allocate memory\n");
+		return -ENOMEM;
 
 	asf_dev->mmio_cfg.use_mmio = true;
 	asf_dev->port_addr = platform_get_resource(pdev, IORESOURCE_IO, 0);
-- 
2.34.1