linux-kernel - Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <124e3fbe79660eac9d529b127d888ce6942ba346.camel@collabora.com>
Date: Wed, 20 Aug 2025 15:27:21 +0200
From: Julien Massot <julien.massot@...labora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	kernel@...labora.com, Michael Turquette <mturquette@...libre.com>, Stephen
 Boyd	 <sboyd@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski	 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Matthias Brugger	 <matthias.bgg@...il.com>, Ikjoon Jang
 <ikjn@...omium.org>, Enric Balletbo i Serra <eballetbo@...nel.org>, Chen-Yu
 Tsai <wenst@...omium.org>, Weiyi Lu	 <weiyi.lu@...iatek.com>, Eugen Hristev
 <eugen.hristev@...aro.org>, Liam Girdwood <lgirdwood@...il.com>, Mark Brown
 <broonie@...nel.org>, Julien Massot <jmassot@...labora.com>,  Sean Wang
 <sean.wang@...nel.org>, Linus Walleij <linus.walleij@...aro.org>
Cc: linux-clk@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org, linux-sound@...r.kernel.org, 
	linux-gpio@...r.kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains
 property

Hi Angelo,

On Mon, 2025-08-04 at 09:59 +0200, AngeloGioacchino Del Regno wrote:
> Il 01/08/25 13:18, Julien Massot ha scritto:
> > The mt8183-mfgcfg node uses a power domain in its device tree node.
> > To prevent schema validation warnings, add the optional `power-domains`
> > property to the binding schema for mediatek syscon clocks.
> > 
> > Fixes: 1781f2c46180 ("arm64: dts: mediatek: mt8183: Add power-domains property to mfgcfg")
> > Signed-off-by: Julien Massot <julien.massot@...labora.com>
> 
> Is MT8183 the only one?
> 
> if:
>    properties:
>      compatible:
>        contains:
>          - const: mediatek,mt8183-mfgcfg
>          ^^^^^^^(if it's not just mt8183, this should be an enum)
> 
> then:
>    properties:
>      power-domains: true
> else:
>    properties:
>      power-domains: false
> 
> (check if the above is correct, don't blindly trust what I wrote! :P)
> 
> 
Verified on my side 'mediatek,mt8183-mfgcfg' is the only one with a power-domain
property.
I will add the if/else and disable the power-domains property for other compatible
as suggested.

> 
> after which:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> (if it's not only mt8183, keep the R-b on this commit regardless)
Thanks,

Julien