linux-kernel - Re: [PATCH net-next v3 07/23] eth: bnxt: read the page size from the adapter struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55e8116d-7bff-4116-a5cf-d96cf95e02d8@gmail.com>
Date: Wed, 20 Aug 2025 14:43:25 +0100
From: Pavel Begunkov <asml.silence@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
 Eric Dumazet <edumazet@...gle.com>, Willem de Bruijn <willemb@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, andrew+netdev@...n.ch, horms@...nel.org,
 davem@...emloft.net, sdf@...ichev.me, dw@...idwei.uk,
 michael.chan@...adcom.com, dtatulea@...dia.com, ap420073@...il.com,
 linux-kernel@...r.kernel.org, io-uring@...r.kernel.org
Subject: Re: [PATCH net-next v3 07/23] eth: bnxt: read the page size from the
 adapter struct

On 8/19/25 20:37, Mina Almasry wrote:
> On Mon, Aug 18, 2025 at 6:56 AM Pavel Begunkov <asml.silence@...il.com> wrote:
>>
>> From: Jakub Kicinski <kuba@...nel.org>
>>
>> Switch from using a constant to storing the BNXT_RX_PAGE_SIZE
>> inside struct bnxt. This will allow configuring the page size
>> at runtime in subsequent patches.
>>
>> The MSS size calculation for older chip continues to use the constant.
>> I'm intending to support the configuration only on more recent HW,
>> looks like on older chips setting this per queue won't work,
>> and that's the ultimate goal.
>>
>> This patch should not change the current behavior as value
>> read from the struct will always be BNXT_RX_PAGE_SIZE at this stage.
>>
>> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
>> Signed-off-by: Pavel Begunkov <asml.silence@...il.com>
> 
> Reviewed-by: Mina Almasry <almasrymina@...gle.com>
> 
> nit: AFAIU BNXT_RX_PAGE_SIZE should be unused after this? You could
> delete the definition in bnxt.h if so.

Still used in a couple of places, notably as the minimum and/or
default size

-- 
Pavel Begunkov