linux-kernel - Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKXT_HOrY1XUlsLu@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 16:56:12 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Dixit Parmar <dixitparmar19@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v4 1/2] iio: magnetometer: add support for Infineon
 TLV493D 3D Magentic sensor

On Wed, Aug 20, 2025 at 10:16:29AM +0530, Dixit Parmar wrote:
> On Sat, Aug 16, 2025 at 02:04:48PM +0100, Jonathan Cameron wrote:

...

> > > +	TLV493D_AXIS_X,
> > > +	TLV493D_AXIS_Y,
> > > +	TLV493D_AXIS_Z,
> > > +	TLV493D_TEMPERATURE
> > As below.
> > 
> > > +};
> > > +
> > > +enum tlv493d_op_mode {
> > > +	TLV493D_OP_MODE_POWERDOWN,
> > > +	TLV493D_OP_MODE_FAST,
> > > +	TLV493D_OP_MODE_LOWPOWER,
> > > +	TLV493D_OP_MODE_ULTRA_LOWPOWER,
> > > +	TLV493D_OP_MODE_MASTERCONTROLLED
> > This is not a terminating entry, so would typically have a trailing comma.
> Isn't the last entry in the enum list is termintating entry and it should
> not have trailing comma?

No, it's not semantically. (Yes, it's terminating the list syntactically)

> > > +};

-- 
With Best Regards,
Andy Shevchenko