linux-kernel - Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKXXTcqpi-6TjWrU@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 17:10:21 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Michael Ellerman <mpe@...erman.id.au>,
	Nicholas Piggin <npiggin@...il.com>,
	Naveen N Rao <naveen@...nel.org>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v2 1/1] powerpc/8xx: Drop legacy-of-mm-gpiochip.h header

On Thu, Aug 14, 2025 at 10:33:52AM +0200, Christophe Leroy wrote:
> Le 18/11/2024 à 13:31, Andy Shevchenko a écrit :
> > Remove legacy-of-mm-gpiochip.h header file. The above mentioned
> > file provides an OF API that's deprecated. There is no agnostic
> > alternatives to it and we have to open code the logic which was
> > hidden behind of_mm_gpiochip_add_data(). Note, most of the GPIO
> > drivers are using their own labeling schemas and resource retrieval
> > that only a few may gain of the code deduplication, so whenever
> > alternative is appear we can move drivers again to use that one.
> > 
> > As a side effect this change fixes a potential memory leak on
> > an error path, if of_mm_gpiochip_add_data() fails.
> 
> Is there a reason for having done this change in cpm1_gpiochip_add16() and
> cpm1_gpiochip_add32() [arch/powerpc/platform/8xx/cpm1.c] and not in
> cpm2_gpiochip_add32() [arch/powerpc/sysdev/cpm_common.c] while all three
> functions are called from cpm_gpio_probe() [arch/powerpc/sysdev/cpm_gpio.c]
> ?

No specific reason, just lack of time to have got all of the cases.

-- 
With Best Regards,
Andy Shevchenko