linux-kernel - Re: [PATCH net] net: pse-pd: pd692x0: Fix power budget leak in manager setup error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d02c9ad2-ea89-4e82-80ad-6d8359f154a1@web.de>
Date: Wed, 20 Aug 2025 16:08:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Kory Maincent <kory.maincent@...tlin.com>, netdev@...r.kernel.org,
 Jakub Kicinski <kuba@...nel.org>, Oleksij Rempel <o.rempel@...gutronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH net] net: pse-pd: pd692x0: Fix power budget leak in
 manager setup error path

…
> +++ b/drivers/net/pse-pd/pd692x0.c
…
> @@ -1185,31 +1217,27 @@ static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev)
…
> +	pd692x0_of_put_managers(priv, manager, nmanagers);
> +	return 0;

How do you think about to apply the following code variant?

	ret = 0;
	goto put_managers;

>  
> -		for (j = 0; j < manager[i].nports; j++)
> -			of_node_put(manager[i].port_node[j]);
> -		of_node_put(manager[i].node);
> -	}
> +err_managers_req_pw:

free_pw_budget:

> +	pd692x0_managers_free_pw_budget(priv);
> +err_of_managers:

put_managers:

> +	pd692x0_of_put_managers(priv, manager, nmanagers);
>  	return ret;
>  }
…

Regards,
Markus