linux-kernel - Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKXaI0SAAMaHMZM9@smile.fi.intel.com>
Date: Wed, 20 Aug 2025 17:22:27 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Haixu Cui <quic_haixcui@...cinc.com>
Cc: harald.mommer@....qualcomm.com, quic_msavaliy@...cinc.com,
	broonie@...nel.org, virtio-dev@...ts.linux.dev,
	viresh.kumar@...aro.org, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org, hdanton@...a.com,
	qiang4.zhang@...ux.intel.com, alex.bennee@...aro.org,
	quic_ztu@...cinc.com
Subject: Re: [PATCH v4 2/3] virtio-spi: Add virtio-spi.h

On Wed, Aug 20, 2025 at 04:49:43PM +0800, Haixu Cui wrote:
> Add virtio-spi.h header for virtio SPI.

...

> +/**

This is kernel-doc comment...

> + * struct virtio_spi_config - All config fields are read-only for the
> + * Virtio SPI driver

> + */

...

> +/*
> + * @chip_select_id: chipselect index the SPI transfer used.
> + *

But this one (besides having tons of unneeded blank lines) is not. Why is this
inconsistency?

> + */

...

> +struct spi_transfer_result {
> +#define VIRTIO_SPI_TRANS_OK	0
> +#define VIRTIO_SPI_PARAM_ERR	1
> +#define VIRTIO_SPI_TRANS_ERR	2
> +	__u8 result;
> +};

And this data type has no doc at all...


-- 
With Best Regards,
Andy Shevchenko