linux-kernel - Re: [PATCH -resend] edac: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250820162418.GLaKX2soq1RgYCAPCA@fat_crate.local>
Date: Wed, 20 Aug 2025 18:24:18 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: linux-kernel@...r.kernel.org, tglx@...utronix.de,
	Dinh Nguyen <dinguyen@...nel.org>, Tony Luck <tony.luck@...el.com>,
	James Morse <james.morse@....com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org
Subject: Re: [PATCH -resend] edac: Use dev_fwnode()

On Wed, Jul 23, 2025 at 08:26:31AM +0200, Jiri Slaby (SUSE) wrote:
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
> 
> So use the dev_fwnode() helper.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Dinh Nguyen <dinguyen@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: James Morse <james.morse@....com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Robert Richter <rric@...nel.org>
> Link: https://lore.kernel.org/all/4bc0e1ca-a523-424a-8759-59e353317fba@kernel.org/
> 
> ---
> Cc: linux-edac@...r.kernel.org
> ---
>  drivers/edac/altera_edac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index cae52c654a15..cfd17a8e5865 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -2131,8 +2131,8 @@ static int altr_edac_a10_probe(struct platform_device *pdev)
>  	edac->irq_chip.name = pdev->dev.of_node->name;
>  	edac->irq_chip.irq_mask = a10_eccmgr_irq_mask;
>  	edac->irq_chip.irq_unmask = a10_eccmgr_irq_unmask;
> -	edac->domain = irq_domain_create_linear(of_fwnode_handle(pdev->dev.of_node),
> -						64, &a10_eccmgr_ic_ops, edac);
> +	edac->domain = irq_domain_create_linear(dev_fwnode(&pdev->dev), 64, &a10_eccmgr_ic_ops,
> +						edac);
>  	if (!edac->domain) {
>  		dev_err(&pdev->dev, "Error adding IRQ domain\n");
>  		return -ENOMEM;
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette