linux-kernel - Re: [PATCH v2 0/4] ASoC: codecs: wcd937x/8x/9x: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aKYDmBYyQI2TjTQ6@vaman>
Date: Wed, 20 Aug 2025 22:49:20 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
Cc: broonie@...nel.org, yung-chuan.liao@...ux.intel.com,
	pierre-louis.bossart@...ux.dev, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.com, krzysztof.kozlowski@...aro.org,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 0/4] ASoC: codecs: wcd937x/8x/9x: cleanup

On 15-08-25, 06:32, Srinivas Kandagatla wrote:
> Hi Vinod,
> On 7/4/25 1:12 PM, srinivas.kandagatla@....qualcomm.com wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@....qualcomm.com>
> > 
> > All these 3 codecs have been duplicating two of the soundwire
> > functions. Noticed another new driver starting to do the same, its time
> > to make some helpers so that we do not duplicate these functions.
> > 
> > I have added two helpers of_sdw_find_device_by_node() and
> > sdw_slave_get_current_bank() in soundwire layer for the codecs to use them.
> > 
> > Changes since v1:
> > 	- updated sdw_slave_get_current_bank do error checks on read
> > 
> > Srinivas Kandagatla (4):
> >   soundwire: bus: add of_sdw_find_device_by_node helper
> >   soundwire: bus: add sdw_slave_get_current_bank helper
> 
> 
> Do you have any comments these two soundwire patches in this series?

Yes I am nota  helpers like this, but I dont think it is big deal so:

Acked-by: Vinod Koul <vkoul@...nel.org>

-- 
~Vinod