linux-kernel - Re: [PATCH] ASoC: SOF: imx: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1fa8baa-3116-496c-8c33-bdbc1712c062@sirena.org.uk>
Date: Wed, 20 Aug 2025 18:26:28 +0100
From: Mark Brown <broonie@...nel.org>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>
Cc: Daniel Baluta <daniel.baluta@...il.com>,
	Xichao Zhao <zhao.xichao@...o.com>,
	Laurentiu Mihalcea <laurentiu.mihalcea@....com>,
	lgirdwood@...il.com, peter.ujfalusi@...ux.intel.com,
	yung-chuan.liao@...ux.intel.com, ranjani.sridharan@...ux.intel.com,
	daniel.baluta@....com, perex@...ex.cz, tiwai@...e.com,
	shawnguo@...nel.org, s.hauer@...gutronix.de,
	kai.vehmanen@...ux.intel.com, pierre-louis.bossart@...ux.dev,
	kernel@...gutronix.de, festevam@...il.com,
	linux-sound@...r.kernel.org, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: SOF: imx: Remove the use of dev_err_probe()

On Wed, Aug 20, 2025 at 12:24:40PM +0300, Laurentiu Mihalcea wrote:
> On 8/20/2025 10:04 AM, Daniel Baluta wrote:
> > On Tue, Aug 19, 2025 at 2:29 PM Xichao Zhao <zhao.xichao@...o.com> wrote:

> >> The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> >> Therefore, remove the useless call to dev_err_probe(), and just
> >> return the value instead.

> > NACK on this.

> > Quote from dev_err_probe documentation:
> >
> > ```
> >  Using this helper in your probe function is totally fine even if @err

> AFAIK the kernel logs are verbose enough on OOM errors, which makes prints
> 
> such as the ones removed by this series unneeded (have a look at [1]). Normally,
> 
> you'd get a warning from checkpatch but I think these logs slipped through the
> 
> cracks because the error messages do not quite match the expected format?

Indeed, there's generally no need for any additional logging on OOM and
if the code is fixed there's no possibility of deferral.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)