linux-kernel - Re: [PATCH] dmaengine: idxd: Fix double free in idxd_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <175571155469.80631.13707540161368362564.b4-ty@kernel.org>
Date: Wed, 20 Aug 2025 23:09:14 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Shuai Xue <xueshuai@...ux.alibaba.com>, 
 Colin Ian King <colin.i.king@...il.com>, 
 Dan Carpenter <dan.carpenter@...aro.org>
Cc: Vinicius Costa Gomes <vinicius.gomes@...el.com>, 
 Dave Jiang <dave.jiang@...el.com>, Fenghua Yu <fenghuay@...dia.com>, 
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Fix double free in idxd_setup_wqs()


On Mon, 11 Aug 2025 13:43:39 +0300, Dan Carpenter wrote:
> The clean up in idxd_setup_wqs() has had a couple bugs because the error
> handling is a bit subtle.  It's simpler to just re-write it in a cleaner
> way.  The issues here are:
> 
> 1) If "idxd->max_wqs" is <= 0 then we call put_device(conf_dev) when
>    "conf_dev" hasn't been initialized.
> 2) If kzalloc_node() fails then again "conf_dev" is invalid.  It's
>    either uninitialized or it points to the "conf_dev" from the
>    previous iteration so it leads to a double free.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: idxd: Fix double free in idxd_setup_wqs()
      commit: 39aaa337449e71a41d4813be0226a722827ba606

Best regards,
-- 
~Vinod