linux-kernel - RE: [PATCH] drm/amd/display: clean-up dead code in dml2_mall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <BL1PR12MB5144269A278EED9AC3CCEE7EF733A@BL1PR12MB5144.namprd12.prod.outlook.com>
Date: Wed, 20 Aug 2025 17:54:53 +0000
From: "Deucher, Alexander" <Alexander.Deucher@....com>
To: Brahmajit Das <listout@...tout.xyz>, "Koenig, Christian"
	<Christian.Koenig@....com>, Alex Deucher <alexdeucher@...il.com>, "Lei, Jun"
	<Jun.Lei@....com>, "Zhuo, Lillian" <Qingqing.Zhuo@....com>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>
Subject: RE: [PATCH] drm/amd/display: clean-up dead code in dml2_mall_phantom

[Public]

> -----Original Message-----
> From: Brahmajit Das <listout@...tout.xyz>
> Sent: Tuesday, August 19, 2025 4:42 PM
> To: Koenig, Christian <Christian.Koenig@....com>; Alex Deucher
> <alexdeucher@...il.com>; Lei, Jun <Jun.Lei@....com>; Zhuo, Lillian
> <Qingqing.Zhuo@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>
> Cc: linux-kernel@...r.kernel.org; amd-gfx@...ts.freedesktop.org;
> listout@...tout.xyz
> Subject: [PATCH] drm/amd/display: clean-up dead code in dml2_mall_phantom
>
> pipe_idx in function dml2_svp_validate_static_schedulabilit, although set is never
> actually used. While building with GCC 16 this gives a
> warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml2_mall_phantom.c: In function
> ‘set_phantom_stream_timing’:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml2_mall_phantom.c:657:25:
> warning: variable ‘pipe_idx’ set but not used [-Wunused-but-set-variable=]
>   657 |         unsigned int i, pipe_idx;
>       |                         ^~~~~~~~
>
> Signed-off-by: Brahmajit Das <listout@...tout.xyz>
> ---
>  drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c
> b/drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c
> index a56e75cdf712..1d0af0f8ffa1 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_mall_phantom.c
> @@ -654,14 +654,13 @@ static void set_phantom_stream_timing(struct
> dml2_context *ctx, struct dc_state
>                                    unsigned int svp_height,
>                                    unsigned int svp_vstartup)
>  {
> -     unsigned int i, pipe_idx;
>       double line_time, fp_and_sync_width_time;
>       struct pipe_ctx *pipe;
>       uint32_t phantom_vactive, phantom_bp, pstate_width_fw_delay_lines;
>       static const double cvt_rb_vblank_max = ((double) 460 / (1000 * 1000));
>
>       // Find DML pipe index (pipe_idx) using dc_pipe_idx
> -     for (i = 0, pipe_idx = 0; i < ctx->config.dcn_pipe_count; i++) {
> +     for (unsigned int i = 0; i < ctx->config.dcn_pipe_count; i++) {

Better to leave this declaration above otherwise other compilers may complain about mixed code and declarations.

Alex

>               pipe = &state->res_ctx.pipe_ctx[i];
>
>               if (!pipe->stream)
> @@ -669,8 +668,6 @@ static void set_phantom_stream_timing(struct
> dml2_context *ctx, struct dc_state
>
>               if (i == dc_pipe_idx)
>                       break;
> -
> -             pipe_idx++;
>       }
>
>       // Calculate lines required for pstate allow width and FW processing delays
> --
> 2.51.0