linux-kernel - Re: [PATCH v5] platform/x86: Add WMI driver for Redmibook keyboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42588e0f-b510-42e0-b4d4-e1e8860d90a2@foxido.dev>
Date: Wed, 20 Aug 2025 21:10:03 +0300
From: Gladyshev Ilya <foxido@...ido.dev>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Armin Wolf <w_armin@....de>, linux-input@...r.kernel.org,
 Hans de Goede <hansg@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
 platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v5] platform/x86: Add WMI driver for Redmibook keyboard.

[resend because I forgot to Cc mailing list... sorry]

On 8/19/25 13:22, Ilpo Järvinen wrote:
 >> +
 >> +    payload = get_unaligned_le32(obj->buffer.pointer);
 >> +    struct key_entry *entry = 
sparse_keymap_entry_from_scancode(data->input_dev, payload);
 >
 > Please only define variables at the beginning of some block (in this 
case,
 > at the beginning of the function).
 >
 > The only exception to this rule are cleanup.h related variables which may
 > have to be defined mid-function to ensure the correct teardown order of
 > the auto variables.

Oh, sorry, was blinded by a same mistake on another line in a hurry... 
Fixed in v6 [1].

By the way, shouldn't it be some checkpatch.pl warning in the ideal 
world? Just sounds like a "why not" task to do in my spare time, so I'd 
like to clarify in advance)

[1] -- 
https://lore.kernel.org/platform-driver-x86/20250820174140.41410-1-foxido@foxido.dev/

-- 
Gladyshev Ilya