linux-kernel - Re: [PATCH] of: reserved_mem: Add missing IORESOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx_DqgEt0e8ZGikTyLWS+2vaTfz=m3BnZJROgGNcp6CwWA@mail.gmail.com>
Date: Wed, 20 Aug 2025 13:51:07 -0700
From: Saravana Kannan <saravanak@...gle.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Patrice CHOTARD <patrice.chotard@...s.st.com>, 
	Arnaud Pouliquen <arnaud.pouliquen@...s.st.com>, Daniel Baluta <daniel.baluta@....com>, 
	Iuliana Prodan <iuliana.prodan@....com>, Daniel Baluta <daniel.baluta@...il.com>, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: reserved_mem: Add missing IORESOURCE_MEM flag on resources

On Wed, Aug 20, 2025 at 12:29 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
> Commit f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse
> "memory-region"') failed to set IORESOURCE_MEM flag on the resources.
> The result is functions such as devm_ioremap_resource_wc() will fail.
> Add the missing flag.
>
> Fixes: f4fcfdda2fd8 ('of: reserved_mem: Add functions to parse "memory-region"')
> Reported-by: Iuliana Prodan <iuliana.prodan@....com>
> Reported-by: Daniel Baluta <daniel.baluta@...il.com>
> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>

Reviewed-by: Saravana Kannan <saravanak@...gle.com>

-Saravana

> ---
>  drivers/of/of_reserved_mem.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 77016c0cc296..d3b7c4ae429c 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -771,6 +771,7 @@ int of_reserved_mem_region_to_resource(const struct device_node *np,
>                 return -EINVAL;
>
>         resource_set_range(res, rmem->base, rmem->size);
> +       res->flags = IORESOURCE_MEM;
>         res->name = rmem->name;
>         return 0;
>  }
> --
> 2.50.1
>