linux-kernel - Re: [PATCH 1/2] drm/i915: set O_LARGEFILE in __create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <r5xlolrlcu76f7c2a2wu75rrdekgdmxgxv6dh7jydpvb3x7ili@bzjzdhokv5xq>
Date: Wed, 20 Aug 2025 20:31:49 -0100
From: Andi Shyti <andi.shyti@...nel.org>
To: 陈涛涛 Taotao Chen <chentaotao@...iglobal.com>
Cc: "jani.nikula@...ux.intel.com" <jani.nikula@...ux.intel.com>, 
	"joonas.lahtinen@...ux.intel.com" <joonas.lahtinen@...ux.intel.com>, "rodrigo.vivi@...el.com" <rodrigo.vivi@...el.com>, 
	"tursulin@...ulin.net" <tursulin@...ulin.net>, "airlied@...il.com" <airlied@...il.com>, 
	"simona@...ll.ch" <simona@...ll.ch>, "oe-lkp@...ts.linux.dev" <oe-lkp@...ts.linux.dev>, 
	"lkp@...el.com" <lkp@...el.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>, "brauner@...nel.org" <brauner@...nel.org>, 
	"oliver.sang@...el.com" <oliver.sang@...el.com>
Subject: Re: [PATCH 1/2] drm/i915: set O_LARGEFILE in __create_shmem()

Hi Taotao,

> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202508081029.343192ec-lkp@intel.com

...

> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> index e3d188455f67..2b53aad915f5 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
> @@ -514,6 +514,11 @@ static int __create_shmem(struct drm_i915_private *i915,
>  	if (IS_ERR(filp))
>  		return PTR_ERR(filp);
>  
> +	/*
> +	 * Prevent -EFBIG by allowing large writes beyond MAX_NON_LFS on shmem
> +	 * objects by setting O_LARGEFILE.
> +	 */
> +	filp->f_flags |= O_LARGEFILE;

I don't have anything against this, but is it really fixing the
issue? I thought that O_LARGEFILE is ignored in 64 bit machines,
while here the failure is happening in 64 bit machines.

Besides, where do you see in the LKP logs the -EFBIG error
message?

Andi

>  	obj->filp = filp;
>  	return 0;
>  }
> -- 
> 2.34.1