linux-kernel - Re: [PATCH] misc: ad525x_dpot: Use str_enabled_disabled() in sysfs_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <AAE18711-427E-4A40-9798-AFEBD24743C3@linux.dev>
Date: Wed, 20 Aug 2025 23:46:20 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Michael Hennerich <michael.hennerich@...log.com>,
 Arnd Bergmann <arnd@...db.de>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: ad525x_dpot: Use str_enabled_disabled() in
 sysfs_show_reg()

On 20. Aug 2025, at 13:15, Greg Kroah-Hartman wrote:
> On Wed, Aug 20, 2025 at 12:27:34PM +0200, Thorsten Blum wrote:
>> Remove hard-coded strings by using the str_enabled_disabled() helper
>> function and silence the following Coccinelle/coccicheck warning
>> reported by string_choices.cocci:
>> 
>>  opportunity for str_enabled_disabled(..)
>> 
>> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
>> ---
> 
> If you are going to change this, might as well call sysfs_emit() as
> well, right?

I guess, but probably in another patch because it's two separate things?

> that way you get two coccicheck warnings at once :)

I didn't look into it, but device_attr_show.cocci doesn't produce any
warnings for drivers/misc/* (at least not for me).

Thanks,
Thorsten