linux-kernel - Re: [PATCH v5] mfd: dt-bindings: ti,twl6040: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175572712295.1429558.12540417914156224115.robh@kernel.org>
Date: Wed, 20 Aug 2025 16:58:43 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Jihed Chaibi <jihed.chaibi.dev@...il.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	conor+dt@...nel.org, peter.ujfalusi@...il.com, krzk+dt@...nel.org,
	lee@...nel.org, shuah@...nel.org
Subject: Re: [PATCH v5] mfd: dt-bindings: ti,twl6040: convert to DT schema


On Sun, 17 Aug 2025 23:52:34 +0200, Jihed Chaibi wrote:
> Convert the legacy TXT binding for the TWL6040 MFD to the modern YAML
> DT schema format. This adds formal validation and improves documentation
> for the TWL6040/TWL6041 audio codec, which provides audio, vibra, and GPO
> functionality on OMAP4+ platforms.
> 
> Key changes:
> 
>  - Dropped usage of the 'twl6040,audpwron-gpio' property from the schema
>    as it is not used by the driver.
>  - Retained 'clocks' and 'clock-names' as flexible (1-2 items) to match
>    the original binding's "and/or" phrasing, which allows clk32k, mclk,
>    or both.
>  - Updated node name to 'audio-codec@4b' to follow generic naming
>    conventions per the Device Tree specification.
>  - Replaced raw interrupt values with standard defines for clarity.
> 
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> 
> ---
> Changes in v5:
>  - Add missing changelogs
> 
> Changes in v4:
>  - Retained 'clocks' and 'clock-names' as flexible (1-2 items) to match
>    the original binding's "and/or" phrasing, which sould allow either
>    clk32k, mclk, or both.
>  - Updated node name to 'audio-codec@4b' to follow generic naming
>    conventions per the Device Tree specification.
>  - Replaced raw interrupt values with standard defines for clarity.
>  - Added clock properties to the example.
> 
> Changes in v3:
>  - Drop usage of The unused 'twl6040,audpwron-gpio' property from the
>    schema as it is not used by the driver.
>  - This patch was originally part of a larger series but has been
>    sent separately per maintainer feedback.
>    v2 (origial patch series) link:
>    https://lore.kernel.org/all/20250814132129.138943-3-jihed.chaibi.dev@gmail.com
> 
> Changes in v2:
>  - Renamed twl6040,audpwron-gpio to ti,audpwron-gpio for consistency
>    with TI naming, this fixes the dt_binding_check vendor name  error.
>  - Minor description clarifications for improved readability.
> 
> Changes in v1:
>  - Initial conversion of twl6040.txt to YAML format.
>  - v1 link :
>    https://lore.kernel.org/all/20250811224739.53869-3-jihed.chaibi.dev@gmail.com/
> ---
>  .../devicetree/bindings/mfd/ti,twl6040.yaml   | 154 ++++++++++++++++++
>  .../devicetree/bindings/mfd/twl6040.txt       |  67 --------
>  2 files changed, 154 insertions(+), 67 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/ti,twl6040.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mfd/twl6040.txt
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>