linux-kernel - Re: [PATCH 0/4] Enable Remote GPIO over RPMSG on i.MX Platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB918595311BFD2BE1DC0CFD7D8933A@PAXPR04MB9185.eurprd04.prod.outlook.com>
Date: Wed, 20 Aug 2025 22:29:36 +0000
From: Shenwei Wang <shenwei.wang@....com>
To: Mathieu Poirier <mathieu.poirier@...aro.org>
CC: Bjorn Andersson <andersson@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Linus
 Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>,
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam
	<festevam@...il.com>, Peng Fan <peng.fan@....com>,
	"linux-remoteproc@...r.kernel.org" <linux-remoteproc@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH 0/4] Enable Remote GPIO over RPMSG on i.MX Platform



> -----Original Message-----
> From: Mathieu Poirier <mathieu.poirier@...aro.org>
> Sent: Wednesday, August 20, 2025 3:49 PM
> To: Shenwei Wang <shenwei.wang@....com>
> Cc: Bjorn Andersson <andersson@...nel.org>; Rob Herring <robh@...nel.org>;
> Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley
> <conor+dt@...nel.org>; Shawn Guo <shawnguo@...nel.org>; Sascha Hauer
> <s.hauer@...gutronix.de>; Linus Walleij <linus.walleij@...aro.org>; Bartosz
> Golaszewski <brgl@...ev.pl>; Pengutronix Kernel Team
> <kernel@...gutronix.de>; Fabio Estevam <festevam@...il.com>; Peng Fan
> <peng.fan@....com>; linux-remoteproc@...r.kernel.org;
> devicetree@...r.kernel.org; imx@...ts.linux.dev; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; dl-linux-imx <linux-
> imx@....com>
> Subject: [EXT] Re: [PATCH 0/4] Enable Remote GPIO over RPMSG on i.MX
> Platform
> 
> 
> Did you send me a patchset that doesn't clear checkpatch.pl?
> 

There is one known warning:
WARNING: function definition argument 'struct rpmsg_device *' should also have an identifier name
#268: FILE: include/linux/imx_rpmsg.h:51:
+	int (*rx_callback)(struct rpmsg_device *, void *, int, void *, u32);

I just kept the format as the existing style. If it is required to be fixed, I will update it in next version. 

Regards,
Shenwei

> On Mon, Aug 18, 2025 at 03:44:16PM -0500, Shenwei Wang wrote:
> > Support the remote devices on the remote processor via the RPMSG bus
> > on i.MX platform.
> >
> > The expected DTS layout structure is following:
> >
> >     cm33: remoteproc-cm33 {
> >              compatible = "fsl,imx8ulp-cm33";
> >
> >              rpmsg {
> >                      rpmsg-io-channel {
> >                              gpio@0 {
> >                                      compatible = "fsl,imx-rpmsg-gpio";
> >                                      reg = <0>;
> >                              };
> >
> >                              gpio@1 {
> >                                      compatible = "fsl,imx-rpmsg-gpio";
> >                                      reg = <1>;
> >                              };
> >
> >                              ...
> >                      };
> >
> >                      rpmsg-i2c-channel {
> >                              i2c@0 {
> >                                      compatible = "fsl,imx-rpmsg-i2c";
> >                                      reg = <0>;
> >                              };
> >                      };
> >
> >                      ...
> >              };
> >      };
> >
> >
> > Shenwei Wang (4):
> >   dt-bindings: remoteproc: imx_rproc: Add "rpmsg" subnode support
> >   remoteproc: imx_rproc: Populate devices under "rpmsg" subnode
> >   gpio: imx-rpmsg: add imx-rpmsg GPIO driver
> >   arm64: dts: imx8ulp: Add rpmsg node under imx_rproc
> >
> >  .../bindings/remoteproc/fsl,imx-rproc.yaml    | 117 ++++
> >  arch/arm64/boot/dts/freescale/imx8ulp.dtsi    |  27 +
> >  drivers/gpio/Kconfig                          |  11 +
> >  drivers/gpio/Makefile                         |   1 +
> >  drivers/gpio/gpio-imx-rpmsg.c                 | 559 ++++++++++++++++++
> >  drivers/remoteproc/imx_rproc.c                | 125 ++++
> >  include/linux/imx_rpmsg.h                     |  55 ++
> >  7 files changed, 895 insertions(+)
> >  create mode 100644 drivers/gpio/gpio-imx-rpmsg.c  create mode 100644
> > include/linux/imx_rpmsg.h
> >
> > --
> > 2.43.0
> >