linux-kernel - Re: [PATCH v1 1/2] dt-bindings: media: i2c: document Sony IMX111 CMOS sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPVz0n1ETyYiaaw_ixEUeJM7xTqoRgcqmB0APige6=NNWsRDPg@mail.gmail.com>
Date: Wed, 20 Aug 2025 08:36:11 +0300
From: Svyatoslav Ryhel <clamor95@...il.com>
To: Rob Herring <robh@...nel.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Hans Verkuil <hverkuil@...all.nl>, Hans de Goede <hansg@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Dongcheng Yan <dongcheng.yan@...el.com>, André Apitzsch <git@...tzsch.eu>, 
	Sylvain Petinot <sylvain.petinot@...s.st.com>, 
	Benjamin Mugnier <benjamin.mugnier@...s.st.com>, 
	Heimir Thor Sverrisson <heimir.sverrisson@...il.com>, Jingjing Xiong <jingjing.xiong@...el.com>, 
	linux-media@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: media: i2c: document Sony IMX111 CMOS sensor

вт, 19 серп. 2025 р. о 23:25 Rob Herring <robh@...nel.org> пише:
>
> On Tue, Aug 19, 2025 at 03:04:26PM +0300, Svyatoslav Ryhel wrote:
> > Add bindings for Sony IMX111 CMOS Digital Image Sensor found in LG
> > Optimus 4X (P880) and Optimus Vu (P895) smartphones.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@...il.com>
> > ---
> >  .../bindings/media/i2c/sony,imx111.yaml       | 126 ++++++++++++++++++
> >  1 file changed, 126 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml
> > new file mode 100644
> > index 000000000000..52d88f5d477e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx111.yaml
> > @@ -0,0 +1,126 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx111.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony IMX111 8MP CMOS Digital Image Sensor
> > +
> > +maintainers:
> > +  - Svyatoslav Ryhel <clamor95@...il.com>
> > +
> > +description:
> > +  IMX111 sensor is a Sony CMOS active pixel digital image sensor with an active
> > +  array size of 2464H x 3280V. It is programmable through I2C interface. Image
> > +  data is sent through MIPI CSI-2, through 1 or 2 lanes.
> > +
> > +allOf:
> > +  - $ref: /schemas/media/video-interface-devices.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: sony,imx111
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description: EXTCLK with possible frequency from 6 to 54 MHz
> > +    maxItems: 1
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +  iovdd-supply:
> > +    description: Digital IO power supply (1.8V)
> > +
> > +  dvdd-supply:
> > +    description: Digital power supply (1.2V)
> > +
> > +  avdd-supply:
> > +    description: Analog power supply (2.7V)
> > +
> > +  eeprom:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description:
> > +      A phandle to the node of the eeprom, that holds sensors configuration data.
>
> This assumes the eeprom is dedicated to the sensor. What if it is just a
> subset of some eeprom or other storage. Perhaps this should use nvmem
> binding.
>
> > +
> > +  flash-leds: true
> > +  lens-focus: true
> > +
> > +  orientation: true
> > +  rotation: true
>
> Use 'unevaluatedProperties' instead and drop these.
>
> > +
> > +  assigned-clocks: true
> > +  assigned-clock-rates: true
> > +  assigned-clock-parents: true
>
> Always allowed on nodes with 'clocks', so drop.
>

All your suggestions are valid and were applied, thank you!