linux-kernel - Re: linux-next: manual merge of the pinctrl-renesas tree with the pinctrl tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWj6dQqmdFYuHPEPL0pxefZ8m9kA5Dq_ZA+YRw4vLvreQ@mail.gmail.com>
Date: Wed, 20 Aug 2025 09:02:17 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Thierry Bultel <thierry.bultel.yh@...renesas.com>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: manual merge of the pinctrl-renesas tree with the
 pinctrl tree

Hi Stephen,

On Wed, 20 Aug 2025 at 05:02, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> After merging the pinctrl-renesas tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/pinctrl/renesas/pinctrl-rzt2h.c:161:14: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>   161 |         func = pinmux_generic_get_function(pctldev, func_selector);
>       |              ^
>
> Caused by commit
>
>   90f2896d7dbb ("pinctrl: renesas: Add support for RZ/T2H")
>
> interacting with commit
>
>   afe1af86ff05 ("pinctrl: constify pinmux_generic_get_function()")
>
> from the pinctrl tree.

Thanks for your report!

> I have applied the following merge fix patch.
>
> From: Stephen Rothwell <sfr@...b.auug.org.au>
> Date: Wed, 20 Aug 2025 12:42:30 +1000
> Subject: [PATCH] fix up for "pinctrl: renesas: Add support for RZ/T2H"
>
> interacting with commit
>
>   afe1af86ff05 ("pinctrl: constify pinmux_generic_get_function()")
>
> from the pinctrl tree.
>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

> --- a/drivers/pinctrl/renesas/pinctrl-rzt2h.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzt2h.c
> @@ -151,7 +151,7 @@ static int rzt2h_pinctrl_set_mux(struct pinctrl_dev *pctldev,
>                                  unsigned int group_selector)
>  {
>         struct rzt2h_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
> -       struct function_desc *func;
> +       const struct function_desc *func;
>         struct group_desc *group;
>         const unsigned int *pins;
>         unsigned int i;

I will fold this fix into commit 90f2896d7dbb ("pinctrl: renesas:
Add support for RZ/T2H"), as it does not depend on commit afe1af86ff05
("pinctrl: constify pinmux_generic_get_function()").

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds