linux-kernel - Re: [PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX queues with COE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22947f6b-03f3-4ee5-974b-aa4912ea37a3@altera.com>
Date: Wed, 20 Aug 2025 12:44:18 +0530
From: "G Thomas, Rohan" <rohan.g.thomas@...era.com>
To: Jakub Kicinski <kuba@...nel.org>,
 Rohan G Thomas via B4 Relay <devnull+rohan.g.thomas.altera.com@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Serge Semin <fancer.lancer@...il.com>,
 Romain Gantois <romain.gantois@...tlin.com>,
 Jose Abreu <Jose.Abreu@...opsys.com>,
 Ong Boon Leong <boon.leong.ong@...el.com>, netdev@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Matthew Gerlach <matthew.gerlach@...era.com>
Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Set CIC bit only for TX
 queues with COE

Hi Jakub,

Thanks for reviewing the patch.

On 8/20/2025 6:52 AM, Jakub Kicinski wrote:
> On Sat, 16 Aug 2025 00:55:25 +0800 Rohan G Thomas via B4 Relay wrote:
>> +	bool csum = !priv->plat->tx_queues_cfg[queue].coe_unsupported;
> 
> Hopefully the slight pointer chasing here doesn't impact performance?
> XDP itself doesn't support checksum so perhaps we could always pass
> false?

I'm not certain whether some XDP applications might be benefiting from
checksum offloading currently, and so passing false unconditionally
could cause regressions.

Best Regards,
Rohan