linux-kernel - Re: [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250820-shapeless-devout-pig-defdd7@kuoka>
Date: Wed, 20 Aug 2025 10:09:23 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chuan Liu <chuan.liu@...ogic.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, 
	Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible
 property for clk-measure

On Fri, Aug 15, 2025 at 04:37:31PM +0800, Chuan Liu wrote:
> The clk-measure IPs across Amlogic SoCs have minimal differences, so
> they can be managed with a unified compatible property.
> 
> Signed-off-by: Chuan Liu <chuan.liu@...ogic.com>
> ---
>  .../bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> index 1c9d37eef5f0..a7927acde2fe 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> @@ -15,15 +15,7 @@ maintainers:
>  
>  properties:
>    compatible:
> -    enum:
> -      - amlogic,meson-gx-clk-measure
> -      - amlogic,meson8-clk-measure
> -      - amlogic,meson8b-clk-measure
> -      - amlogic,meson-axg-clk-measure
> -      - amlogic,meson-g12a-clk-measure
> -      - amlogic,meson-sm1-clk-measure
> -      - amlogic,c3-clk-measure
> -      - amlogic,s4-clk-measure
> +    const: amlogic,clk-measure

Obviously NAK, cannot stress more how wrong your approach is. It defies
all rules for writing bindings.

Best regards,
Krzysztof