linux-kernel - Re: [PATCH 08/13] arm64: dts: amlogic: Unify the compatible property for clk-measure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250820-sweet-herring-of-luck-9c3431@kuoka>
Date: Wed, 20 Aug 2025 10:11:47 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Chuan Liu <chuan.liu@...ogic.com>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, 
	Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, 
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/13] arm64: dts: amlogic: Unify the compatible property
 for clk-measure

On Fri, Aug 15, 2025 at 04:37:34PM +0800, Chuan Liu wrote:
> The clk-measure IPs across Amlogic SoCs have minimal differences, so
> they can be managed with a unified compatible property.
> 
> Signed-off-by: Chuan Liu <chuan.liu@...ogic.com>
> ---
>  arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi       | 2 +-
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 2 +-
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi         | 2 +-
>  arch/arm64/boot/dts/amlogic/meson-s4.dtsi         | 2 +-
>  arch/arm64/boot/dts/amlogic/meson-sm1.dtsi        | 1 -
>  6 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> index ab9ebabce171..570cac451d63 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-c3.dtsi
> @@ -761,7 +761,7 @@ internal_ephy: ethernet_phy@8 {
>  			};
>  
>  			clk_msr: clock-measure@...00 {
> -				compatible = "amlogic,c3-clk-measure";
> +				compatible = "amlogic,clk-measure";

NAK

Don't ever send such broken code. You just affect all users without any
valid reason. This patchset is horrible.

Best regards,
Krzysztof