linux-kernel - Re: [PATCH v4] iommu/riscv: prevent NULL deref in iova_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250820092128.8069-1-huangxianliang@lanxincomputing.com>
Date: Wed, 20 Aug 2025 17:21:28 +0800
From: "XianLiang Huang" <huangxianliang@...xincomputing.com>
To: <markus.elfring@....de>
Cc: <alex@...ti.fr>, <aou@...s.berkeley.edu>, 
	<huangxianliang@...xincomputing.com>, <iommu@...ts.linux.dev>, 
	<joro@...tes.org>, <linux-kernel@...r.kernel.org>, 
	<linux-riscv@...ts.infradead.org>, <palmer@...belt.com>, 
	<paul.walmsley@...ive.com>, <robin.murphy@....com>, 
	<tjeznach@...osinc.com>, <will@...nel.org>
Subject: Re: [PATCH v4] iommu/riscv: prevent NULL deref in iova_to_phys

https://lore.kernel.org/lkml/feb46658-5a3a-4403-b407-500566280eb3@web.de/

I updated the patch in v3, and updated change description accordingly:

In v1
> -	if (_io_pte_none(*ptr) || !_io_pte_present(*ptr))
> +	if (!ptr || _io_pte_none(*ptr) || !_io_pte_present(*ptr))

In v3
> -	if (_io_pte_none(*ptr) || !_io_pte_present(*ptr))
> +	if (!ptr)

but put your proposal at the patch Subject...
  v1: check pte null pointer before use
  v3: prevent NULL deref in iova_to_phys

> …> ---
> > Changes
> > v4:
> > - Change the summary as Markus recommends
> > 
> > v3:
sorry for making this messy.

Regards,
Xianliang