linux-kernel - Re: [PATCH v7 0/7] Add SEV-SNP CipherTextHiding feature support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e1740fa2-f26c-4c3b-b139-b31dd654bea6@amd.com>
Date: Tue, 19 Aug 2025 20:17:08 -0500
From: "Kalra, Ashish" <ashish.kalra@....com>
To: Sean Christopherson <seanjc@...gle.com>, Borislav Petkov <bp@...en8.de>
Cc: Kim Phillips <kim.phillips@....com>,
 Herbert Xu <herbert@...dor.apana.org.au>, Neeraj.Upadhyay@....com,
 aik@....com, akpm@...ux-foundation.org, ardb@...nel.org, arnd@...db.de,
 corbet@....net, dave.hansen@...ux.intel.com, davem@...emloft.net,
 hpa@...or.com, john.allen@....com, kvm@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, michael.roth@....com, mingo@...hat.com,
 nikunj@....com, paulmck@...nel.org, pbonzini@...hat.com,
 rostedt@...dmis.org, tglx@...utronix.de, thomas.lendacky@....com,
 x86@...nel.org
Subject: Re: [PATCH v7 0/7] Add SEV-SNP CipherTextHiding feature support

Hello Sean,

On 8/19/2025 7:05 PM, Sean Christopherson wrote:
> On Tue, Aug 19, 2025, Borislav Petkov wrote:
>> On Mon, Aug 18, 2025 at 02:38:38PM -0500, Kim Phillips wrote:
>>> I have pending comments on patch 7:
>>
>> If you're so hell-bent on doing your improvements on-top or aside of them, you
>> take his patch, add your stuff ontop or rewrite it, test it and then you send
>> it out and say why yours is better.
>>
>> Then the maintainer decides.
>>
>> There's no need to debate ad absurdum - you simply offer your idea and the
>> maintainer decides which one is better. As it has always been done.
> 
> Or, the maintainer says "huh!?" and goes with option C.
> 
> Why take a string in the first place?  Just use '-1' as "max/auto".

It's just that there was general feedback to use a string like "max".

But as a maintainer if you are suggesting to use '-1' as "max/auto", i can do that.

Thanks,
Ashish