linux-kernel - Re: [PATCH net-next v3 3/5] ethtool: netlink: add lightweight MSE reporting to LINKSTATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250820115220.1655e5ff@kmaincent-XPS-13-7390>
Date: Wed, 20 Aug 2025 11:52:20 +0200
From: Kory Maincent <kory.maincent@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, Jakub Kicinski <kuba@...nel.org>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Donald Hunter
 <donald.hunter@...il.com>, Jonathan Corbet <corbet@....net>, Heiner
 Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>, Nishanth Menon
 <nm@...com>, kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
 linux-doc@...r.kernel.org, Michal Kubecek <mkubecek@...e.cz>, Roan van Dijk
 <roan@...tonic.nl>
Subject: Re: [PATCH net-next v3 3/5] ethtool: netlink: add lightweight MSE
 reporting to LINKSTATE_GET

Le Tue, 19 Aug 2025 09:12:54 +0200,
Oleksij Rempel <o.rempel@...gutronix.de> a écrit :

> Extend ETHTOOL_MSG_LINKSTATE_GET to optionally return a simplified
> Mean Square Error (MSE) reading alongside existing link status fields.
> 
> The new attributes are:
>   - ETHTOOL_A_LINKSTATE_MSE_VALUE: current average MSE value
>   - ETHTOOL_A_LINKSTATE_MSE_MAX: scale limit for the reported value
>   - ETHTOOL_A_LINKSTATE_MSE_CHANNEL: source channel selector
> 
> This path reuses the PHY MSE core API, but only retrieves a single
> value intended for quick link-health checks:
>   * If the PHY supports a WORST channel selector, report its current
>     average MSE.
>   * Otherwise, if LINK-wide measurements are supported, report those.
>   * If neither is available, omit the attributes.
> 
> Unlike the full MSE_GET interface, LINKSTATE_GET does not expose
> per-channel or peak/worst-peak values and incurs minimal overhead.
> Drivers that implement get_mse_config() / get_mse_snapshot() will
> automatically populate this data.
> 
> The intent is to provide tooling with a “fast path” health indicator
> without issuing a separate MSE_GET request, though the long-term
> overlap with the full interface may need reevaluation.

Reviewed-by: Kory Maincent <kory.maincent@...tlin.com>

Thank you!

-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com