linux-kernel - Re: [PATCH v2] pwm: berlin: Fix wrong register in suspend/resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dpo6rhrcn6eapfupv72cl3i3eeaqexla5embodk5ook4hew5tr@biyqxthux4kj>
Date: Wed, 20 Aug 2025 13:05:22 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm: berlin: Fix wrong register in suspend/resume

Hello,

On Tue, Aug 19, 2025 at 07:42:24PM +0800, Jisheng Zhang wrote:
> The 'enable' register should be BERLIN_PWM_EN rather than
> BERLIN_PWM_ENABLE, otherwise, the driver accesses wrong address, there
> will be cpu exception then kernel panic during suspend/resume.
> 
> Fixes: bbf0722c1c66 ("pwm: berlin: Add suspend/resume support")
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
> since v1:
>  - update commit log to mention cpu exception then kernel panic w/o
>    the patch

Applied this patch to

https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/fixes

with a Cc: stable now. Given this issue is nearly 9 years old I'm not
sure yet this fix is urgent enough to justify a fixes PR to Linus.

However there are two such patches now, so maybe I will prepare another
pull request before 6.17. But for now I will give it a few days in next
first.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)