linux-kernel - Re: [PATCH] selftests: harness: Rework is_signed_type() to avoid collision with overflow.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18f2ea68-0f7c-465e-917e-e079335995c1@sirena.org.uk>
Date: Wed, 20 Aug 2025 12:11:58 +0100
From: Mark Brown <broonie@...nel.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Kees Cook <kees@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH] selftests: harness: Rework is_signed_type() to avoid
 collision with overflow.h

On Tue, Jun 24, 2025 at 04:19:30PM -0700, Sean Christopherson wrote:
> Rename is_signed_type() to is_signed_var() to avoid colliding with a macro
> of the same name defined by linux/overflow.h.  Note, overflow.h's version
> takes a type as the input, whereas the harness's version takes a variable!

This patch is in -next and is causing widespread breakage in the
selftests -next on at least arm and arm64 due to:

make --silent --keep-going --jobs=15 O=/build/stage/build-work INSTALL_PATH=/build/stage/build-work/kselftest_install ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- kselftest-install

...

In file included from test-pcmtest-driver.c:10:
../kselftest_harness.h:59:10: fatal error: linux/overflow.h: No such file or directory
   59 | #include <linux/overflow.h>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

Sample build log:

   https://builds.sirena.org.uk/5303936d609e09665deda94eaedf26a0e5c3a087/arm64/defconfig/build.log

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)