linux-kernel - RE: [PATCH] iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <MN2PR12MB4223B775F240DFD91C6131138B33A@MN2PR12MB4223.namprd12.prod.outlook.com>
Date: Wed, 20 Aug 2025 12:31:12 +0000
From: "O'Griofa, Conall" <conall.ogriofa@....com>
To: Sean Anderson <sean.anderson@...ux.dev>, Anand Ashok Dumbre
	<anand.ashok.dumbre@...inx.com>, Jonathan Cameron <jic23@...nel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC: Andy Shevchenko <andy@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Simek, Michal" <michal.simek@....com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, David Lechner
	<dlechner@...libre.com>, Manish Narani <manish.narani@...inx.com>,
	Nuno Sá <nuno.sa@...log.com>
Subject: RE: [PATCH] iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK

Hi,

Good spot, thanks again!

Cheers,
Conall.

> -----Original Message-----
> From: Sean Anderson <sean.anderson@...ux.dev>
> Sent: 15 July 2025 01:31
> To: Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>; Jonathan Cameron
> <jic23@...nel.org>; linux-iio@...r.kernel.org
> Cc: Andy Shevchenko <andy@...nel.org>; linux-kernel@...r.kernel.org; Simek,
> Michal <michal.simek@....com>; linux-arm-kernel@...ts.infradead.org; David
> Lechner <dlechner@...libre.com>; Manish Narani <manish.narani@...inx.com>;
> Nuno Sá <nuno.sa@...log.com>; Sean Anderson <sean.anderson@...ux.dev>
> Subject: [PATCH] iio: xilinx-ams: Fix AMS_ALARM_THR_DIRECT_MASK
> 
> AMS_ALARM_THR_DIRECT_MASK should be bit 0, not bit 1. This would cause
> hysteresis to be enabled with a lower threshold of -28C. The temperature alarm
> would never deassert even if the temperature dropped below the upper threshold.
> 
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>
> ---
> 
>  drivers/iio/adc/xilinx-ams.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index
> 76dd0343f5f7..552190dd0e6e 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -118,7 +118,7 @@
>  #define AMS_ALARM_THRESHOLD_OFF_10	0x10
>  #define AMS_ALARM_THRESHOLD_OFF_20	0x20
> 
> -#define AMS_ALARM_THR_DIRECT_MASK	BIT(1)
> +#define AMS_ALARM_THR_DIRECT_MASK	BIT(0)
>  #define AMS_ALARM_THR_MIN		0x0000
>  #define AMS_ALARM_THR_MAX		(BIT(16) - 1)
> 
> --
> 2.35.1.1320.gc452695387.dirty

Reviewed-by: O'Griofa, Conall <conall.ogriofa@....com>