linux-kernel - Re: [PATCH] media: venus: firmware: Use correct reset sequence for IRIS2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9c318b7c-544c-df55-eead-e00244d2992f@quicinc.com>
Date: Thu, 21 Aug 2025 17:34:44 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>
CC: Dikshita Agarwal <quic_dikshita@...cinc.com>,
        Mauro Carvalho Chehab
	<mchehab@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Hans Verkuil
	<hverkuil@...nel.org>, <linux-media@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: venus: firmware: Use correct reset sequence for
 IRIS2


On 8/20/2025 8:46 PM, Stephan Gerhold wrote:
> When starting venus with the "no_tz" code path, IRIS2 needs the same
> boot/reset sequence as IRIS2_1. This is because most of the registers were
> moved to the "wrapper_tz_base", which is already defined for both IRIS2 and
> IRIS2_1 inside core.c. Add IRIS2 to the checks inside firmware.c as well to
> make sure that it uses the correct reset sequence.
> 
> Both IRIS and IRIS2_1 are HFI v6 variants, so the correct sequence was used

s/IRIS/IRIS2

> before commit c38610f8981e ("media: venus: firmware: Sanitize
> per-VPU-version").
> 
> Fixes: c38610f8981e ("media: venus: firmware: Sanitize per-VPU-version")
> Signed-off-by: Stephan Gerhold <stephan.gerhold@...aro.org>
> ---
>  drivers/media/platform/qcom/venus/firmware.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

with that addressed,
Reviewed-by: Vikash Garodia <quic_vgarodia@...cinc.com>