linux-kernel - Re: [PATCH 7/7] iio: temperature: mlx90635: Remove dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vd+p1kPPZyrkOsE7EUpCEjd0ii+uHR69EvGNbbDOFuA6w@mail.gmail.com>
Date: Thu, 21 Aug 2025 15:46:42 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Crt Mori <cmo@...exis.com>
Cc: Xichao Zhao <zhao.xichao@...o.com>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, 
	"open list:MELEXIS MLX90635 DRIVER" <linux-iio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/7] iio: temperature: mlx90635: Remove dev_err_probe() if
 error is -ENOMEM

On Thu, Aug 21, 2025 at 2:47 PM Crt Mori <cmo@...exis.com> wrote:
>
> I am not sure I agree with this. It provides an error message with
> reason and I understand we want as few as possible, but this would be
> a valid remark inside the logs?

How? dev_err_probe() is no-op for ENOMEM.

Also there is an agreement inside the kernel community that ENOMEM
errors need no log, as if it's the case, we have much bigger issues
than that.

> On Thu, 21 Aug 2025 at 10:08, Xichao Zhao <zhao.xichao@...o.com> wrote:
> >
> > The dev_err_probe() doesn't do anything when error is '-ENOMEM'.
> > Therefore, remove the useless call to dev_err_probe(), and just
> > return the value instead.

With all that said, the series is correct and good to go. I don't see
obstacles otherwise.

-- 
With Best Regards,
Andy Shevchenko