linux-kernel - Re: [PATCH v1 04/14] net: dt-bindings: Convert Marvell 8897/8997 bindings to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <175578240744.3438740.13033328475024605529.robh@kernel.org>
Date: Thu, 21 Aug 2025 08:24:52 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
Cc: flora.fu@...iatek.com, chunkuang.hu@...nel.org, broonie@...nel.org, 
 linux-gpio@...r.kernel.org, mripard@...nel.org, 
 louisalexis.eyraud@...labora.com, mchehab@...nel.org, 
 kyrie.wu@...iatek.corp-partner.google.com, lgirdwood@...il.com, 
 linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com, 
 conor+dt@...nel.org, kernel@...labora.com, 
 linux-arm-kernel@...ts.infradead.org, amergnat@...libre.com, 
 netdev@...r.kernel.org, tiffany.lin@...iatek.com, 
 linux-input@...r.kernel.org, airlied@...il.com, linux-clk@...r.kernel.org, 
 jeesw@...fas.com, yunfei.dong@...iatek.com, linus.walleij@...aro.org, 
 sean.wang@...nel.org, linux-media@...r.kernel.org, 
 linux-sound@...r.kernel.org, tzimmermann@...e.de, 
 andrew-ct.chen@...iatek.com, minghsiu.tsai@...iatek.com, simona@...ll.ch, 
 kuba@...nel.org, jmassot@...labora.com, devicetree@...r.kernel.org, 
 linux-mediatek@...ts.infradead.org, houlong.wei@...iatek.com, 
 angelogioacchino.delregno@...labora.com, andrew+netdev@...n.ch, 
 support.opensource@...semi.com, maarten.lankhorst@...ux.intel.com, 
 ck.hu@...iatek.com, matthias.bgg@...il.com, pabeni@...hat.com, 
 p.zabel@...gutronix.de, edumazet@...gle.com, krzk+dt@...nel.org, 
 davem@...emloft.net, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v1 04/14] net: dt-bindings: Convert Marvell 8897/8997
 bindings to YAML


On Wed, 20 Aug 2025 14:12:52 -0300, Ariel D'Alessandro wrote:
> Convert the existing text-based DT bindings for Marvell 8897/8997
> (sd8897/sd8997) bluetooth devices controller to a YAML schema.
> 
> While here, bindings for "usb1286,204e" (USB interface) are dropped from
> the YAML definition as these are currently documented in file:
> 
> - Documentation/devicetree/bindings/net/btusb.txt
> 
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@...labora.com>
> ---
>  .../bindings/net/marvell,sd8897-bt.yaml       | 91 +++++++++++++++++++
>  .../bindings/net/marvell-bt-8xxx.txt          | 83 -----------------
>  2 files changed, 91 insertions(+), 83 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml: marvell,wakeup-gap-ms: missing type definition
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/marvell,sd8897-bt.example.dtb: bluetooth@2 (marvell,sd8897-bt): marvell,wakeup-gap-ms: b'\x00d' is not of type 'object', 'integer', 'array', 'boolean', 'null'
	from schema $id: http://devicetree.org/schemas/dt-core.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/net/btusb.txt references a file that doesn't exist: Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt
Documentation/devicetree/bindings/net/btusb.txt: Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250820171302.324142-5-ariel.dalessandro@collabora.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.