linux-kernel - Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <175578240828.3438836.9383803134622022528.robh@kernel.org>
Date: Thu, 21 Aug 2025 08:24:53 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Conor Dooley <conor+dt@...nel.org>, Guenter Roeck <groeck@...omium.org>, 
 Tim Harvey <tharvey@...eworks.com>, Mathew McBride <matt@...verse.com.au>, 
 Lee Jones <lee@...nel.org>, Benson Leung <bleung@...omium.org>, 
 chrome-platform@...ts.linux.dev, Michael Walle <mwalle@...nel.org>, 
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>
Subject: Re: [PATCH] dt-bindings: mfd: Move embedded controllers to own
 directory


On Thu, 21 Aug 2025 08:28:41 +0200, Krzysztof Kozlowski wrote:
> Move ChromeOS Embedded Controller, Gateworks System Controller and
> Kontron sl28cpld Board Management Controller to new subdirectory
> "embedded-controller" matching their purpose.  MFD is coming from Linux
> and does not really fit the actual purpose of this hardware.
> 
> Rename Gateworks GSC filename to match compatible, as preferred for
> bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Cc: Mathew McBride <matt@...verse.com.au>
> 
> Lee,
> Can you take it via MFD?
> ---
>  .../bindings/{mfd => embedded-controller}/google,cros-ec.yaml | 2 +-
>  .../gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml}    | 2 +-
>  .../{mfd => embedded-controller}/kontron,sl28cpld.yaml        | 2 +-
>  MAINTAINERS                                                   | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)
>  rename Documentation/devicetree/bindings/{mfd => embedded-controller}/google,cros-ec.yaml (99%)
>  rename Documentation/devicetree/bindings/{mfd/gateworks-gsc.yaml => embedded-controller/gw,gsc.yaml} (98%)
>  rename Documentation/devicetree/bindings/{mfd => embedded-controller}/kontron,sl28cpld.yaml (97%)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml:
	Error in referenced schema matching $id: http://devicetree.org/schemas/mfd/google,cros-ec.yaml
	Tried these paths (check schema $id if path is wrong):
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
	/usr/local/lib/python3.13/dist-packages/dtschema/schemas/mfd/google,cros-ec.yaml

/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8192-scp): cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8192-scp): cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8195-scp-dual): scp@0:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8195-scp-dual): scp@...00:cros-ec-rpmsg: {'compatible': ['google,cros-ec-rpmsg'], 'mediatek,rpmsg-name': ['cros-ec-rpmsg']} should not be valid under {'description': "Can't find referenced schema: http://devicetree.org/schemas/mfd/google,cros-ec.yaml#"}
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mtk,scp.example.dtb: scp@...00000 (mediatek,mt8195-scp-dual): scp@...00:cros-ec-rpmsg: Unevaluated properties are not allowed ('compatible', 'mediatek,rpmsg-name' were unexpected)
	from schema $id: http://devicetree.org/schemas/remoteproc/mtk,scp.yaml#

doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Warning: Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml references a file that doesn't exist: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml
Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml: Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250821062840.9383-2-krzysztof.kozlowski@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.