linux-kernel - Re: [PATCH net] phy: mscc: Fix when PTP clock is register and unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f8cef10-fbfd-42b7-8ab7-f15d46938eb3@linux.dev>
Date: Thu, 21 Aug 2025 14:50:35 +0100
From: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
To: Horatiu Vultur <horatiu.vultur@...rochip.com>, andrew@...n.ch,
 hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 richardcochran@...il.com, vladimir.oltean@....com,
 rmk+kernel@...linux.org.uk, rosenp@...il.com, christophe.jaillet@...adoo.fr,
 viro@...iv.linux.org.uk, atenart@...nel.org, quentin.schulz@...tlin.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] phy: mscc: Fix when PTP clock is register and
 unregister

On 21/08/2025 11:46, Horatiu Vultur wrote:
> +static void __vsc8584_deinit_ptp(struct phy_device *phydev)
> +{
> +	struct vsc8531_private *vsc8531 = phydev->priv;
>   
> -	vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps,
> -						     &phydev->mdio.dev);
> -	return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock);
> +	ptp_clock_unregister(vsc8531->ptp->ptp_clock);
> +	skb_queue_purge(&vsc8531->rx_skbs_list);
>   }
>   
>   void vsc8584_config_ts_intr(struct phy_device *phydev)
> @@ -1552,6 +1549,18 @@ int vsc8584_ptp_init(struct phy_device *phydev)
>   	return 0;
>   }
>   
> +void vsc8584_ptp_deinit(struct phy_device *phydev)
> +{
> +	switch (phydev->phy_id & phydev->drv->phy_id_mask) {
> +	case PHY_ID_VSC8572:
> +	case PHY_ID_VSC8574:
> +	case PHY_ID_VSC8575:
> +	case PHY_ID_VSC8582:
> +	case PHY_ID_VSC8584:
> +		return __vsc8584_deinit_ptp(phydev);

void function has no return value. as well as it shouldn't return
anything. I'm not quite sure why do you need __vsc8584_deinit_ptp()
at all, I think everything can be coded inside vsc8584_ptp_deinit()

> +	}
> +}