linux-kernel - Re: [PATCH net-next v4 7/7] net: devmem: allow binding on rx queues with same DMA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250821073244.2b1bd1f6@kernel.org>
Date: Thu, 21 Aug 2025 07:32:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Dragos Tatulea <dtatulea@...dia.com>
Cc: almasrymina@...gle.com, asml.silence@...il.com, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, cratiu@...dia.com,
 parav@...dia.com, netdev@...r.kernel.org, sdf@...a.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 7/7] net: devmem: allow binding on rx queues
 with same DMA devices

On Thu, 21 Aug 2025 11:10:57 +0000 Dragos Tatulea wrote:
> > I think we may want to bubble up the Multi-PF thing from the comment to
> > the user. This could be quite confusing to people. How about:
> > 
> > 	"DMA device mismatch between queue %u and %u (multi-PF device?)"  
> Sounds good. Do we still need the comment? A similar remark is done in
> the commit message as well.

I think the comment can go away with the better user-facing message.
The commit msg LGTM as is, doesn't count as extra LoC..