linux-kernel - Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for flexcan1/2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aKc1Qg9aiVsKfMft@lizhi-Precision-Tower-5810>
Date: Thu, 21 Aug 2025 11:03:30 -0400
From: Frank Li <Frank.li@....com>
To: Haibo Chen <haibo.chen@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx95-19x19-evk: correct the phy setting for
 flexcan1/2

On Tue, Aug 19, 2025 at 11:50:17AM -0400, Frank Li wrote:
> On Tue, Aug 19, 2025 at 10:43:37AM +0800, Haibo Chen wrote:
> > 1, the phy support up to 8Mbit/s databitrate for CAN FD.
> >    refer to product data sheet:
> >      https://www.nxp.com/docs/en/data-sheet/TJA1463.pdf
> > 2, the standby pin of the phy is ACTIVE_LOW.
> > 3, the phy of flexcan2 connect the standby/en pin to PCAL6408 on i2c4 bus.
> >
> > Fixes: 02b7adb791e1 ("arm64: dts: imx95-19x19-evk: add adc0 flexcan[1,2] i2c[2,3] uart5 spi3 and tpm3")
> > Signed-off-by: Haibo Chen <haibo.chen@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > index 2f949a0d48d2d8066388884703c3b3cd678f16e1..9d034275c847606919af8ee4a80a00599abf4d8b 100644
> > --- a/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts
> > @@ -80,17 +80,17 @@ linux_cma: linux,cma {
> >  	flexcan1_phy: can-phy0 {
> >  		compatible = "nxp,tjr1443";
> >  		#phy-cells = <0>;
> > -		max-bitrate = <1000000>;
> > +		max-bitrate = <8000000>;
> >  		enable-gpios = <&i2c6_pcal6416 6 GPIO_ACTIVE_HIGH>;
> > -		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_HIGH>;
> > +		standby-gpios = <&i2c6_pcal6416 5 GPIO_ACTIVE_LOW>;
>
> It use go though CAN phy.

Sorry, I mass up. It is correct.

Reviewed-by: Frank Li <Frank.Li@....com>

>
> Frank
> >  	};
> >
> >  	flexcan2_phy: can-phy1 {
> >  		compatible = "nxp,tjr1443";
> >  		#phy-cells = <0>;
> > -		max-bitrate = <1000000>;
> > -		enable-gpios = <&i2c6_pcal6416 4 GPIO_ACTIVE_HIGH>;
> > -		standby-gpios = <&i2c6_pcal6416 3 GPIO_ACTIVE_HIGH>;
> > +		max-bitrate = <8000000>;
> > +		enable-gpios = <&i2c4_gpio_expander_21 4 GPIO_ACTIVE_HIGH>;
> > +		standby-gpios = <&i2c4_gpio_expander_21 3 GPIO_ACTIVE_LOW>;
> >  	};
> >
> >  	reg_vref_1v8: regulator-1p8v {
> >
> > ---
> > base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
> > change-id: 20250819-can-dts-fix-62ac1d02c007
> >
> > Best regards,
> > --
> > Haibo Chen <haibo.chen@....com>
> >